Change the WebSocket OpCode constants to an enum

Change the WebSocket OpCode constants to an enum

In order to permit them to be used in switch statements, changed the
kOpCode* constants to an enum.

Simplified IsKnownDataOpCode() and IsKnownControlOpCode() since the
compiler can now see the values and so produce optimised output with no
need for bit fiddling.

Also applied style fixes suggested by clang-format and cpplint.py.

BUG=
TEST=net_unittests chromedriver_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201086

[yhirano, 2013-05-20 05:06:02]

https://codereview.chromium.org/15298012/diff/1/net/websockets/websocket_frame.h
File net/websockets/websocket_frame.h (right):

https://codereview.chromium.org/15298012/diff/1/net/websockets/websocket_fram...
net/websockets/websocket_frame.h:39: // Efficiently determine whether a given
opcode is one of the data opcodes
Does "Efficiently" means using the bit operation? Then we should modify this
comment, I think.

https://codereview.chromium.org/15298012/diff/1/net/websockets/websocket_fram...
net/websockets/websocket_frame.h:46: // Efficiently determine whether a given
opcode is one of the control opcodes
Ditto

[Adam Rice, 2013-05-20 07:19:49]

https://codereview.chromium.org/15298012/diff/1/net/websockets/websocket_frame.h
File net/websockets/websocket_frame.h (right):

https://codereview.chromium.org/15298012/diff/1/net/websockets/websocket_fram...
net/websockets/websocket_frame.h:39: // Efficiently determine whether a given
opcode is one of the data opcodes
On 2013/05/20 05:06:02, yhirano wrote:
> Does "Efficiently" means using the bit operation? Then we should modify this
> comment, I think.

Originally I wrote "efficiently" to constrast against comparing the values
directly, which was inefficient to users of this header because the values
weren't available at compile time. 

Now that the values are in the header it doesn't make any difference to
efficiency, it is just useful to have a single function to give the answer.

So I have removed the word "Efficiently".

https://codereview.chromium.org/15298012/diff/1/net/websockets/websocket_fram...
net/websockets/websocket_frame.h:46: // Efficiently determine whether a given
opcode is one of the control opcodes
On 2013/05/20 05:06:02, yhirano wrote:
> Ditto

Done.

[yhirano, 2013-05-20 07:30:03]

lgtm

[Adam Rice, 2013-05-20 07:34:18]

Hi toyoshim. Can you give this OWNERS review, if you have time?

[Takashi Toyoshima, 2013-05-20 10:01:43]

lgtm!

[commit-bot: I haz the power, 2013-05-20 11:21:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ricea@chromium.org/15298012/5001

[commit-bot: I haz the power, 2013-05-20 14:40:12]

Change committed as 201086