Issue 15297013: Revert "InstantExtended: Prevent spurious themechanged/mostvisitedchanged events"

Issue 15297013: Revert "InstantExtended: Prevent spurious themechanged/mostvisitedchanged events" (Closed)

Created:
7 years, 7 months ago by Jered

Modified:
7 years, 7 months ago

Reviewers:
samarth

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, sreeram, gideonwald, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "InstantExtended: Prevent spurious themechanged/mostvisitedchanged events" This reverts commit 9fa73739c47280860c0e5a44af62885bee391e12. BUG=238671 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200954

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -41 lines)			Patch
	M	chrome/common/instant_types.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download
	M	chrome/renderer/searchbox/searchbox.cc	View		3 chunks	+0 lines, -37 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jered@chromium.org/15297013/1

7 years, 7 months ago (2013-05-17 18:33:02 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=150465

7 years, 7 months ago (2013-05-17 20:39:05 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jered@chromium.org/15297013/1

7 years, 7 months ago (2013-05-17 22:28:40 UTC) #5

sreeram

On Fri, May 17, 2013 at 11:27 AM, <jered@chromium.org> wrote: > I haven't seen the ...

7 years, 7 months ago (2013-05-18 02:05:15 UTC) #7

sreeram

7 years, 7 months ago (2013-05-18 02:09:29 UTC) #8

On Fri, May 17, 2013 at 7:04 PM, Sreeram Ramachandran
<sreeram@chromium.org> wrote:
> On Fri, May 17, 2013 at 11:27 AM,  <jered@chromium.org> wrote:
>> I haven't seen the behavior problems in local testing.
>
> Can you explain more? Are you saying that even after reverting CL
> 198512, you still don't see bug 225760? If so, how did that happen? I
> am currently OOO, so I can't check easily, so an explanation of how
> that bug doesn't bite would be appreciated.

Never mind. I just read the details on the bug you mentioned in the
revert: 238671. Will continue discussion there.

Expand Messages | Collapse Messages