Issue 1529653002: Prototype FrameletGuest/Container Class stubs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1529653002: Prototype FrameletGuest/Container Class stubs. (Closed)

Created:
5 years ago by wjmaclean

Modified:
4 years, 11 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Prototype FrameletGuest/Container Class stubs. This isn't finished, and the DEPS need some work, but I think it's moving in the right direction. Task 3. BUG=none

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+295 lines, -6 lines)			Patch
M	chrome/browser/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_renderer.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/components.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	components/framelet.gypi	View	1 chunk	+63 lines, -0 lines	0 comments	Download
A	components/framelet/browser/BUILD.gn	View	1 chunk	+22 lines, -0 lines	0 comments	Download
A	components/framelet/browser/framelet_guest.h	View	1 chunk	+39 lines, -0 lines	0 comments	Download
A	components/framelet/browser/framelet_guest.cc	View	1 chunk	+80 lines, -0 lines	0 comments	Download
A	components/framelet/common/BUILD.gn	View	1 chunk	+13 lines, -0 lines	0 comments	Download
A	components/framelet/common/framelet_constants.h	View	1 chunk	+18 lines, -0 lines	0 comments	Download
A	components/framelet/common/framelet_constants.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download
A +	components/framelet/common/framelet_messages.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	components/framelet/renderer/BUILD.gn	View	1 chunk	+8 lines, -6 lines	0 comments	Download
A	components/framelet/renderer/framelet_container.h	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	components/framelet/renderer/framelet_container.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1047683002 Patch 1