Translate: enable against unknown languages with server side detection

chrome/browser/resources/translate.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This code is used in conjunction with the Google Translate Element script.
 // It is injected in a page to translate it from one language to another.
 // It should be included in the page before the Translate Element script.
 
 var cr = {};
 
@@ skipping 111 matching lines @@
      * page.
      * @type {boolean}
      */
     get error() {
       return error;
     },
 
     /**
      * The language the page translated was in. Is valid only after the page
      * has been successfully translated and the original language specified to
      * the translate function was 'auto'. Is empty otherwise.

[Evan Stade, 2013/05/18 23:53:52]

this comment needs updating.

[Takashi Toyoshima, 2013/05/20 06:56:08]

Done.

      * @type {boolean}
      */
     get sourceLang() {
       if (!libReady || !finished || error)
         return '';
+      if (!lib.getDetectedLanguage)
+        return 'und';

[Evan Stade, 2013/05/18 23:53:52]

why 'und' and not undefined or 'undefined' or whatever 'und' is supposed to
stand for?

[Takashi Toyoshima, 2013/05/20 06:56:08]

'und' is a magic word defined as chrome::kUnknownLanguageCode and widely used in
Chrome Translate.
I'll add comment here.

       return lib.getDetectedLanguage();

[Evan Stade, 2013/05/18 23:53:52]

you can write this as lib.getDetectedLanguage() || 'und';

[Takashi Toyoshima, 2013/05/20 06:56:08]

It doesn't work.
Undefined one is not returned value, but lib.getDetectedLanguage itself.
So, when call lib.getDetectedLanguage(), JavaScript stops running due to calling
undefined attribute.

[Evan Stade, 2013/05/23 00:53:28]

ah, I misread it

     },
 
     /**
      * Time in msec from this script being injected to all server side scripts
      * being loaded.
      * @type {number}
      */
     get loadTime() {
       if (loadedTime == 0)
         return 0;
@@ skipping 59 matching lines @@
       } catch (err) {
         error = true;
         return;
       }
       // The TranslateService is not available immediately as it needs to start
       // Flash.  Let's wait until it is ready.
       checkLibReady();
     }
   };
 })/* Calling code '(|key|);' will be appended by TranslateHelper in C++ here. */