Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15294020: StorageMonitor: Make StorageInfo a real class. (Closed)

Created:
7 years, 7 months ago by Lei Zhang
Modified:
7 years, 7 months ago
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, chromium-apps-reviews_chromium.org, sail+watch_chromium.org, Aaron Boodman
Visibility:
Public.

Description

StorageMonitor: Make StorageInfo a real class. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202016

Patch Set 1 : #

Total comments: 6

Patch Set 2 : address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+371 lines, -351 lines) Patch
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_event_router.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/system_info_storage/storage_info_provider.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/media_galleries/media_file_system_registry.cc View 1 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_dialog_controller.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences.cc View 1 4 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_preferences_unittest.cc View 1 16 chunks +61 lines, -61 lines 0 comments Download
M chrome/browser/storage_monitor/image_capture_device_manager_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/media_storage_util.cc View 1 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/storage_monitor/portable_device_watcher_win.cc View 1 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/storage_monitor/storage_info.h View 1 1 chunk +22 lines, -7 lines 0 comments Download
M chrome/browser/storage_monitor/storage_info.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_chromeos.cc View 1 4 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_chromeos_unittest.cc View 1 9 chunks +42 lines, -30 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_linux.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_linux_unittest.cc View 1 8 chunks +32 lines, -35 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_mac.mm View 1 10 chunks +25 lines, -28 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_mac_unittest.mm View 1 5 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_unittest.cc View 1 4 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_win_unittest.cc View 1 6 chunks +25 lines, -25 lines 0 comments Download
M chrome/browser/storage_monitor/test_storage_monitor.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/storage_monitor/test_volume_mount_watcher_win.cc View 1 3 chunks +15 lines, -20 lines 0 comments Download
M chrome/browser/storage_monitor/volume_mount_watcher_win.cc View 1 4 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Lei Zhang
7 years, 7 months ago (2013-05-22 20:52:13 UTC) #1
Greg Billock
I feel some painful merges on the horizon. :-) https://codereview.chromium.org/15294020/diff/77001/chrome/browser/storage_monitor/storage_monitor_mac.mm File chrome/browser/storage_monitor/storage_monitor_mac.mm (right): https://codereview.chromium.org/15294020/diff/77001/chrome/browser/storage_monitor/storage_monitor_mac.mm#newcode64 chrome/browser/storage_monitor/storage_monitor_mac.mm:64: ...
7 years, 7 months ago (2013-05-22 23:39:00 UTC) #2
Lei Zhang
https://codereview.chromium.org/15294020/diff/77001/chrome/browser/storage_monitor/storage_monitor_mac.mm File chrome/browser/storage_monitor/storage_monitor_mac.mm (right): https://codereview.chromium.org/15294020/diff/77001/chrome/browser/storage_monitor/storage_monitor_mac.mm#newcode64 chrome/browser/storage_monitor/storage_monitor_mac.mm:64: CFNumberGetValue(size_number, kCFNumberLongLongType, &(size_in_bytes)); On 2013/05/22 23:39:00, Greg Billock wrote: ...
7 years, 7 months ago (2013-05-23 16:44:49 UTC) #3
Greg Billock
lgtm
7 years, 7 months ago (2013-05-23 18:09:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/15294020/92001
7 years, 7 months ago (2013-05-23 18:16:32 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=153132
7 years, 7 months ago (2013-05-24 01:25:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/15294020/92001
7 years, 7 months ago (2013-05-24 05:30:44 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-24 07:48:42 UTC) #8
Message was sent while issue was closed. 
Change committed as 202016

Powered by Google App Engine
This is Rietveld 408576698