Drop shadows for packaged apps on the OSX App Launcher.

Drop shadows for packaged apps on the OSX App Launcher.

Adds a custom NSButtonCell for AppsGridViewItem that overrides
drawImage to set up a graphics context to draw a shadow, before
calling the superclass implementation.

BUG=138633
TEST=Open OSX app lancher, icons without the shortcut overlay should
have a drop shadow.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201012

[tapted, 2013-05-17 14:30:39]

Hi sail, I this one is ready for review too if you get a chance.

[tapted, 2013-05-17 14:50:39]

https://codereview.chromium.org/15294008/diff/1/ui/app_list/cocoa/apps_grid_v...
File ui/app_list/cocoa/apps_grid_view_item.mm (right):

https://codereview.chromium.org/15294008/diff/1/ui/app_list/cocoa/apps_grid_v...
ui/app_list/cocoa/apps_grid_view_item.mm:269: [shadow setShadowColor:[[NSColor
blackColor] colorWithAlphaComponent:0.14]];
note: source for these numbers
https://code.google.com/p/chromium/codesearch#chromium/src/ui/app_list/views/...

  const gfx::ShadowValue kIconShadows[] = {
    gfx::ShadowValue(gfx::Point(0, 2), 2, SkColorSetARGB(0x24, 0, 0, 0)),
  };
  icon_shadows_.assign(kIconShadows, kIconShadows + arraysize(kIconShadows));

[sail, 2013-05-17 17:41:33]

lgtm

https://codereview.chromium.org/15294008/diff/1/ui/app_list/cocoa/apps_grid_v...
File ui/app_list/cocoa/apps_grid_view_item.mm (right):

https://codereview.chromium.org/15294008/diff/1/ui/app_list/cocoa/apps_grid_v...
ui/app_list/cocoa/apps_grid_view_item.mm:269: [shadow setShadowColor:[[NSColor
blackColor] colorWithAlphaComponent:0.14]];
A more direct way to do this is [NSColor colorWithCalibratedWhite:0 alpha:0.14]

[tapted, 2013-05-17 23:39:30]

Thanks sail!

https://codereview.chromium.org/15294008/diff/1/ui/app_list/cocoa/apps_grid_v...
File ui/app_list/cocoa/apps_grid_view_item.mm (right):

https://codereview.chromium.org/15294008/diff/1/ui/app_list/cocoa/apps_grid_v...
ui/app_list/cocoa/apps_grid_view_item.mm:269: [shadow setShadowColor:[[NSColor
blackColor] colorWithAlphaComponent:0.14]];
On 2013/05/17 17:41:33, sail wrote:
> A more direct way to do this is [NSColor colorWithCalibratedWhite:0
alpha:0.14]

Done.

[commit-bot: I haz the power, 2013-05-17 23:39:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/15294008/6001

[commit-bot: I haz the power, 2013-05-20 04:06:49]

Change committed as 201012