Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15294004: Implement V8ScriptRunner::compileAndRunInternalScript() (Closed)

Created:
7 years, 7 months ago by haraken
Modified:
7 years, 7 months ago
CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, adamk+blink_chromium.org, Nate Chapin
Visibility:
Public.

Description

Implement V8ScriptRunner::compileAndRunInternalScript() Currently Script::Compile() and Script::Run() are written here and there in V8 binding. We should aggregate it into one place. This patch implements V8ScriptRunner::compileAndRunInternalScript() and replace V8GCController's code with the method. I will replace more code with the method. This is one of refactoring to insert TRACE_EVENT_SAMPLING_STATE0 macros. BUG=241743 R=abarth,eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150648

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -22 lines) Patch
M Source/WebKit/chromium/src/WebFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8GCController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8GCController.cpp View 1 2 chunks +3 lines, -20 lines 0 comments Download
M Source/bindings/v8/V8ScriptRunner.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/v8/V8ScriptRunner.cpp View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
haraken
r?
7 years, 7 months ago (2013-05-17 13:03:46 UTC) #1
abarth-chromium
https://codereview.chromium.org/15294004/diff/1/Source/bindings/v8/V8ScriptRunner.cpp File Source/bindings/v8/V8ScriptRunner.cpp (right): https://codereview.chromium.org/15294004/diff/1/Source/bindings/v8/V8ScriptRunner.cpp#newcode68 Source/bindings/v8/V8ScriptRunner.cpp:68: v8::HandleScope handleScope; There's a HandleScope here. https://codereview.chromium.org/15294004/diff/1/Source/bindings/v8/V8ScriptRunner.cpp#newcode70 Source/bindings/v8/V8ScriptRunner.cpp:70: v8::Local<v8::Value> ...
7 years, 7 months ago (2013-05-17 16:21:12 UTC) #2
haraken
https://codereview.chromium.org/15294004/diff/1/Source/bindings/v8/V8ScriptRunner.cpp File Source/bindings/v8/V8ScriptRunner.cpp (right): https://codereview.chromium.org/15294004/diff/1/Source/bindings/v8/V8ScriptRunner.cpp#newcode85 Source/bindings/v8/V8ScriptRunner.cpp:85: return result; Great catch... I have to use HandleScope::Close().
7 years, 7 months ago (2013-05-17 16:23:41 UTC) #3
haraken
Updated the patch. r? https://codereview.chromium.org/15294004/diff/1/Source/bindings/v8/V8ScriptRunner.cpp File Source/bindings/v8/V8ScriptRunner.cpp (right): https://codereview.chromium.org/15294004/diff/1/Source/bindings/v8/V8ScriptRunner.cpp#newcode85 Source/bindings/v8/V8ScriptRunner.cpp:85: return result; Fixed the stale ...
7 years, 7 months ago (2013-05-20 00:32:59 UTC) #4
abarth-chromium
LGTM https://codereview.chromium.org/15294004/diff/6001/Source/bindings/v8/V8ScriptRunner.cpp File Source/bindings/v8/V8ScriptRunner.cpp (right): https://codereview.chromium.org/15294004/diff/6001/Source/bindings/v8/V8ScriptRunner.cpp#newcode87 Source/bindings/v8/V8ScriptRunner.cpp:87: context.clear(); Why the explicit call to clear? In ...
7 years, 7 months ago (2013-05-20 04:16:06 UTC) #5
haraken
https://codereview.chromium.org/15294004/diff/6001/Source/bindings/v8/V8ScriptRunner.cpp File Source/bindings/v8/V8ScriptRunner.cpp (right): https://codereview.chromium.org/15294004/diff/6001/Source/bindings/v8/V8ScriptRunner.cpp#newcode87 Source/bindings/v8/V8ScriptRunner.cpp:87: context.clear(); Fixed to v8::Local.
7 years, 7 months ago (2013-05-20 04:21:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/15294004/11001
7 years, 7 months ago (2013-05-20 04:22:02 UTC) #7
abarth-chromium
https://codereview.chromium.org/15294004/diff/11001/Source/bindings/v8/V8ScriptRunner.cpp File Source/bindings/v8/V8ScriptRunner.cpp (right): https://codereview.chromium.org/15294004/diff/11001/Source/bindings/v8/V8ScriptRunner.cpp#newcode71 Source/bindings/v8/V8ScriptRunner.cpp:71: v8::Local<v8::Value> result; I think you'll need to move this ...
7 years, 7 months ago (2013-05-20 04:23:20 UTC) #8
abarth-chromium
https://codereview.chromium.org/15294004/diff/11001/Source/bindings/v8/V8ScriptRunner.cpp File Source/bindings/v8/V8ScriptRunner.cpp (right): https://codereview.chromium.org/15294004/diff/11001/Source/bindings/v8/V8ScriptRunner.cpp#newcode29 Source/bindings/v8/V8ScriptRunner.cpp:29: #include "bindings/v8/ScopedPersistent.h" This include probably isn't needed anymore.
7 years, 7 months ago (2013-05-20 04:23:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/15294004/23001
7 years, 7 months ago (2013-05-20 04:34:17 UTC) #10
haraken
Thanks, all comments addressed.
7 years, 7 months ago (2013-05-20 04:34:40 UTC) #11
commit-bot: I haz the power
7 years, 7 months ago (2013-05-20 06:31:07 UTC) #12
Message was sent while issue was closed. 
Change committed as 150648

Powered by Google App Engine
This is Rietveld 408576698