Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2890)

Unified Diff: cc/proto/layer.proto

Issue 1527863002: Serialize PictureLayer properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/proto/layer.proto
diff --git a/cc/proto/layer.proto b/cc/proto/layer.proto
index 914ff8a9247571b7c903c25903fcd50c3f6f93e6..69f7d9d9ff4f7ea66e006491ab8527ff6a222099 100644
--- a/cc/proto/layer.proto
+++ b/cc/proto/layer.proto
@@ -4,6 +4,11 @@
syntax = "proto2";
+import "display_list_recording_source.proto";
+import "size.proto";
+import "rect.proto";
+import "region.proto";
+
package cc.proto;
option optimize_for = LITE_RUNTIME;
@@ -12,6 +17,7 @@ option optimize_for = LITE_RUNTIME;
// facilitate reconstruction of a Layer of the correct type on the client.
enum LayerType {
Base = 1;
+ Picture = 2;
vmpstr 2015/12/16 04:21:08 As I mentined elsewhere, maybe these should match
David Trainor- moved to gerrit 2015/12/16 19:10:58 Done. Also moved to caps to fit chromium style gu
// TODO(nyquist): Add the rest of the necessary LayerTypes.
};
@@ -47,8 +53,22 @@ message LayerProperties {
// The Layer base class and each descendant have different proto messages
// for their specific properties.
optional BaseLayerProperties base = 5;
+
+ // Only one of these fields may be set per LayerProperties.
+ // TODO(dtrainor): use a 'oneof' union when it's supported in Chromium.
vmpstr 2015/12/16 04:21:08 File a bug and reference it here please
David Trainor- moved to gerrit 2015/12/16 19:10:59 Done.
+ optional PictureLayerProperties picture = 6;
}
message BaseLayerProperties {
// TODO(nyquist): Add all the required properties below. Huzzah!
}
+
+message PictureLayerProperties {
+ optional DisplayListRecordingSource recording_source = 1;
+ optional Region invalidation = 2;
+ optional Rect last_updated_visible_layer_rect = 3;
+ optional bool is_mask = 4;
+ optional bool nearest_neighbor = 5;
+
+ optional int64 update_source_frame_number = 6;
+}

Powered by Google App Engine
This is Rietveld 408576698