Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: chrome/browser/history/history_notifications.h

Issue 15275004: bookmarks: Get rid of the dependency on history_notifications.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add files back Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_details.h ('k') | chrome/browser/history/history_notifications.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_notifications.h
diff --git a/chrome/browser/history/history_notifications.h b/chrome/browser/history/history_notifications.h
index 081babdbc69e24769d7581020e3a5c4359a0cd26..afe48f142b2c0d16304988cdb079cacd4fdf10ac 100644
--- a/chrome/browser/history/history_notifications.h
+++ b/chrome/browser/history/history_notifications.h
@@ -8,22 +8,14 @@
#define CHROME_BROWSER_HISTORY_HISTORY_NOTIFICATIONS_H__
#include <set>
-#include <vector>
-#include "googleurl/src/gurl.h"
+#include "chrome/browser/history/history_details.h"
#include "chrome/browser/history/history_types.h"
#include "chrome/browser/search_engines/template_url_id.h"
+#include "googleurl/src/gurl.h"
namespace history {
-// Base class for history notifications. This needs only a virtual destructor
-// so that the history service's broadcaster can delete it when the request
-// is complete.
-struct HistoryDetails {
- public:
- virtual ~HistoryDetails() {}
-};
-
// Details for NOTIFICATION_HISTORY_URL_VISITED.
struct URLVisitedDetails : public HistoryDetails {
URLVisitedDetails();
@@ -69,14 +61,6 @@ struct URLsDeletedDetails : public HistoryDetails {
std::set<GURL> favicon_urls;
};
-// Details for NOTIFY_FAVICON_CHANGED.
-struct FaviconChangeDetails : public HistoryDetails {
- FaviconChangeDetails();
- virtual ~FaviconChangeDetails();
-
- std::set<GURL> urls;
-};
-
// Details for HISTORY_KEYWORD_SEARCH_TERM_UPDATED.
struct KeywordSearchTermDetails : public HistoryDetails {
KeywordSearchTermDetails();
« no previous file with comments | « chrome/browser/history/history_details.h ('k') | chrome/browser/history/history_notifications.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698