chrome/browser/bookmarks/DEPS - Issue 15275004: bookmarks: Get rid of the dependency on history_notifications.h

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/bookmarks/DEPS

Issue 15275004: bookmarks: Get rid of the dependency on history_notifications.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add files back Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_model.cc » ('j') | no next file with comments »

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # Bookmarks is being made into a component (it will end up at	2 # Bookmarks is being made into a component (it will end up at

3 # //components/bookmarks and not depend on //chrome), so we have these basic	3 # //components/bookmarks and not depend on //chrome), so we have these basic

4 # rules followed by temporary exceptions. Please don't add to the list of	4 # rules followed by temporary exceptions. Please don't add to the list of

5 # exceptions!	5 # exceptions!

6 "-chrome/browser",	6 "-chrome/browser",

7 "+chrome/browser/bookmarks",	7 "+chrome/browser/bookmarks",

8 "+chrome/browser/favicon",	8 "+chrome/browser/favicon",

9	9

10 # TODO(kaiwang): Bring this list to zero.	10 # TODO(kaiwang): Bring this list to zero.

11 # Do not add to the list of temporarily-allowed dependencies below,	11 # Do not add to the list of temporarily-allowed dependencies below,

12 # and please do not introduce more #includes of these files.	12 # and please do not introduce more #includes of these files.

13 "!chrome/browser/history/history_notifications.h",

14 "!chrome/browser/history/history_service.h",	13 "!chrome/browser/history/history_service.h",

15 "!chrome/browser/history/history_service_factory.h",	14 "!chrome/browser/history/history_service_factory.h",

16 "!chrome/browser/history/query_parser.h",	15 "!chrome/browser/history/query_parser.h",

17 "!chrome/browser/history/snippet.h",	16 "!chrome/browser/history/snippet.h",

18 "!chrome/browser/history/url_database.h",	17 "!chrome/browser/history/url_database.h",

19 "!chrome/browser/profiles/incognito_helpers.h",	18 "!chrome/browser/profiles/incognito_helpers.h",

20 "!chrome/browser/profiles/profile.h",	19 "!chrome/browser/profiles/profile.h",

21 "!chrome/browser/profiles/profile_dependency_manager.h",	20 "!chrome/browser/profiles/profile_dependency_manager.h",

22 "!chrome/browser/profiles/profile_keyed_service.h",	21 "!chrome/browser/profiles/profile_keyed_service.h",

23 "!chrome/browser/profiles/profile_keyed_service_factory.h",	22 "!chrome/browser/profiles/profile_keyed_service_factory.h",

24 "!chrome/browser/profiles/startup_task_runner_service.h",	23 "!chrome/browser/profiles/startup_task_runner_service.h",

25 "!chrome/browser/profiles/startup_task_runner_service_factory.h",	24 "!chrome/browser/profiles/startup_task_runner_service_factory.h",

26 # Do not add to the list of temporarily-allowed dependencies above,	25 # Do not add to the list of temporarily-allowed dependencies above,

27 # and please do not introduce more #includes of these files.	26 # and please do not introduce more #includes of these files.

28 ]	27 ]

OLD	NEW