Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9618)

Unified Diff: chrome/nacl/nacl_ipc_adapter_unittest.cc

Issue 15274002: Do not translate the file open flags other than read/write. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix win_rel build Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/nacl/nacl_ipc_adapter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/nacl/nacl_ipc_adapter_unittest.cc
diff --git a/chrome/nacl/nacl_ipc_adapter_unittest.cc b/chrome/nacl/nacl_ipc_adapter_unittest.cc
index 8a334d553eb7c1a5d1f8fc391cc33eb98e7f16bf..9258bd1ffc6d07d2ca6179ecd825ac588b556e98 100644
--- a/chrome/nacl/nacl_ipc_adapter_unittest.cc
+++ b/chrome/nacl/nacl_ipc_adapter_unittest.cc
@@ -13,6 +13,8 @@
#include "base/threading/simple_thread.h"
#include "ipc/ipc_test_sink.h"
#include "native_client/src/trusted/desc/nacl_desc_custom.h"
+#include "native_client/src/trusted/service_runtime/include/sys/fcntl.h"
+#include "ppapi/c/ppb_file_io.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
@@ -306,3 +308,37 @@ TEST_F(NaClIPCAdapterTest, ReadWithChannelError) {
thread.Join();
}
+// Tests that TranslatePepperFileOpenFlags translates pepper read/write open
+// flags into NaCl open flags correctly.
+TEST_F(NaClIPCAdapterTest, TranslatePepperFileReadWriteOpenFlags) {
+ EXPECT_EQ(NACL_ABI_O_RDONLY,
+ TranslatePepperFileReadWriteOpenFlagsForTesting(PP_FILEOPENFLAG_READ));
+ EXPECT_EQ(NACL_ABI_O_WRONLY,
+ TranslatePepperFileReadWriteOpenFlagsForTesting(PP_FILEOPENFLAG_WRITE));
+ EXPECT_EQ(NACL_ABI_O_RDWR,
+ TranslatePepperFileReadWriteOpenFlagsForTesting(
+ PP_FILEOPENFLAG_READ | PP_FILEOPENFLAG_WRITE));
+
+ // The flags other than PP_FILEOPENFLAG_READ and PP_FILEOPENFLAG_WRITE are
+ // discared.
+ EXPECT_EQ(NACL_ABI_O_WRONLY,
+ TranslatePepperFileReadWriteOpenFlagsForTesting(
+ PP_FILEOPENFLAG_WRITE | PP_FILEOPENFLAG_CREATE));
+ EXPECT_EQ(NACL_ABI_O_WRONLY,
+ TranslatePepperFileReadWriteOpenFlagsForTesting(
+ PP_FILEOPENFLAG_WRITE | PP_FILEOPENFLAG_TRUNCATE));
+ EXPECT_EQ(NACL_ABI_O_WRONLY,
+ TranslatePepperFileReadWriteOpenFlagsForTesting(
+ PP_FILEOPENFLAG_WRITE | PP_FILEOPENFLAG_EXCLUSIVE));
+
+ // If neither of PP_FILEOPENFLAG_READ and PP_FILEOPENFLAG_WRITE is set, falls
+ // back NACL_ABI_O_READONLY
+ EXPECT_EQ(NACL_ABI_O_RDONLY,
+ TranslatePepperFileReadWriteOpenFlagsForTesting(PP_FILEOPENFLAG_CREATE));
+ EXPECT_EQ(NACL_ABI_O_RDONLY,
+ TranslatePepperFileReadWriteOpenFlagsForTesting(
+ PP_FILEOPENFLAG_TRUNCATE));
+ EXPECT_EQ(NACL_ABI_O_RDONLY,
+ TranslatePepperFileReadWriteOpenFlagsForTesting(
+ PP_FILEOPENFLAG_EXCLUSIVE));
+}
« no previous file with comments | « chrome/nacl/nacl_ipc_adapter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698