Add step generator protocol, remove annotated_checkout, remove script.

scripts/slave/recipes_test/run_presubmit.blink.expected

Index: scripts/slave/recipes_test/run_presubmit.blink.expected
diff --git a/scripts/slave/recipes_test/run_presubmit.blink.expected b/scripts/slave/recipes_test/run_presubmit.blink.expected
index fa898b6c11350eba8020b847ccd495cad4f4fd76..48e434c1ac9b47ccd065b93c8c3ceb56875f3c62 100644
--- a/scripts/slave/recipes_test/run_presubmit.blink.expected
+++ b/scripts/slave/recipes_test/run_presubmit.blink.expected
@@ -1,44 +1,7 @@
 [
-  {
-    "cmd": [
-      "[DEPOT_TOOLS_ROOT]/apply_issue", 
-      "-r", 
-      "[BUILD_ROOT]/slave/fake_slave/build/src/third_party/WebKit", 
-      "-i", 
-      12853011, 
-      "-p", 
-      1, 
-      "-s", 
-      "https://chromiumcodereview.appspot.com", 
-      "-e", 
-      "commit-bot@chromium.org"
-    ], 
-    "name": "apply_issue"
-  }, 
-  {
-    "cmd": [
-      "[DEPOT_TOOLS_ROOT]/presubmit_support.py", 
-      "--root", 
-      "[BUILD_ROOT]/slave/fake_slave/build/src/third_party/WebKit", 
-      "--commit", 
-      "--verbose", 
-      "--verbose", 
-      "--issue", 
-      12853011, 
-      "--patchset", 
-      1, 
-      "--skip_canned", 
-      "CheckRietveldTryJobExecution", 
-      "--skip_canned", 
-      "CheckTreeIsOpen", 
-      "--skip_canned", 
-      "CheckBuildbotPendingBuilds", 
-      "--rietveld_url", 
-      "https://chromiumcodereview.appspot.com", 
-      "--rietveld_email", 
-      "", 
-      "--rietveld_fetch"
-    ], 
-    "name": "presubmit"
-  }
+  {"cmd": ["[DEPOT_TOOLS_ROOT]/gclient", "config", "--spec", "solutions = [{'managed': True, 'custom_vars': {'webkit_trunk': 'svn://svn-mirror.golo.chromium.org/blink/trunk', 'googlecode_url': 'svn://svn-mirror.golo.chromium.org/%s', 'nacl_trunk': 'http://src.chromium.org/native_client/trunk', 'sourceforge_url': 'svn://svn-mirror.golo.chromium.org/%(repo)s'}, 'url': 'svn://svn-mirror.golo.chromium.org/chrome/trunk/src', 'custom_deps': {'src/third_party/WebKit': 'svn://svn-mirror.golo.chromium.org/blink/trunk'}, 'deps_file': 'DEPS', 'safesync_url': '', 'name': 'src'}]\n"], "name": "gclient setup", "seed_steps": ["gclient setup", "gclient clean", "gclient sync"]},

[Mike Stip (use stip instead), 2013/05/18 00:37:22]

really no way to make this rietveld-friendly?

[iannucci, 2013/05/18 04:00:36]

Well... I could leave it like it was, but then it would be basically unreadable
in a normal diff view :/. This actually looks quite decent when viewing the
files in a real viewer.

Part of the ugly here is I totally changed the output format AND caused the
checkout steps to appear in the output, so rietveld thinks I just rewrote
everything.

+  {"cmd": ["[DEPOT_TOOLS_ROOT]/gclient", "revert", "--nohooks"], "name": "gclient clean"},
+  {"cmd": ["[DEPOT_TOOLS_ROOT]/gclient", "sync", "--nohooks"], "name": "gclient sync"},
+  {"cmd": ["[DEPOT_TOOLS_ROOT]/apply_issue", "-r", "[SLAVE_BUILD_ROOT]/src/third_party/WebKit", "-i", 12853011, "-p", 1, "-s", "https://chromiumcodereview.appspot.com", "-e", "commit-bot@chromium.org"], "name": "apply_issue"},
+  {"cmd": ["[DEPOT_TOOLS_ROOT]/presubmit_support.py", "--root", "[SLAVE_BUILD_ROOT]/src/third_party/WebKit", "--commit", "--verbose", "--verbose", "--issue", 12853011, "--patchset", 1, "--skip_canned", "CheckRietveldTryJobExecution", "--skip_canned", "CheckTreeIsOpen", "--skip_canned", "CheckBuildbotPendingBuilds", "--rietveld_url", "https://chromiumcodereview.appspot.com", "--rietveld_email", "", "--rietveld_fetch"], "name": "presubmit"}
 ]