scripts/slave/recipes/toolkit.py - Issue 15270004: Add step generator protocol, remove annotated_checkout, remove script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/toolkit.py

Issue 15270004: Add step generator protocol, remove annotated_checkout, remove script. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Checkout blobs do not need to be generators Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/git_setup.py ('K') | « scripts/slave/recipes/run_presubmit.py ('k') | scripts/slave/recipes_test/gatekeeper.basic.expected » ('j') | scripts/slave/recipes_test/run_presubmit.blink.expected » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/toolkit.py

diff --git a/scripts/slave/recipes/toolkit.py b/scripts/slave/recipes/toolkit.py

index 467d4f89e4dcf7c8e3a16259750343376700e986..b9025501f62d2aa4a88edd0947775aaa53fa1572 100644

--- a/scripts/slave/recipes/toolkit.py

+++ b/scripts/slave/recipes/toolkit.py

@@ -2,12 +2,9 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-def GetFactoryProperties(api, _factory_properties, build_properties):

- return {

- 'checkout': 'git',

- 'git_spec': {

- 'url': build_properties['repository'] + '.git',

- 'recursive': True,

- },

- 'script': api.checkout_path('buildbot', 'gen_steps.py')

- }

+def GetSteps(api, _factory_properties, build_properties):

+ steps = api.Steps(build_properties)

+ return (

+ steps.git_checkout(build_properties['repository'] + '.git', recursive=True),

+ steps.generator_script(api.checkout_path('buildbot', 'gen_steps.py'))

+ )