scripts/slave/recipes/gatekeeper.py - Issue 15270004: Add step generator protocol, remove annotated_checkout, remove script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/gatekeeper.py

Issue 15270004: Add step generator protocol, remove annotated_checkout, remove script. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Address comments and change expected json output format Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipes/gatekeeper.py

diff --git a/scripts/slave/recipes/gatekeeper.py b/scripts/slave/recipes/gatekeeper.py

index ef2ad7a705525195f70f46525a86ad1c6409afb8..92060c34a6ee589244c5093e6685609ed20adaf6 100644

--- a/scripts/slave/recipes/gatekeeper.py

+++ b/scripts/slave/recipes/gatekeeper.py

@@ -4,11 +4,9 @@

"""Specifies how to launch the gatekeeper."""

-def GetFactoryProperties(api, _factory_properties, build_properties):

+def GetSteps(api, _factory_properties, build_properties):

steps = api.Steps(build_properties)

- return {

- 'steps': [

- steps.step('gatekeeper_launch',

- [api.build_path('scripts', 'slave', 'gatekeeper_launch.py')])

- ]

- }

+ return [

+ steps.step('gatekeeper_launch',

+ [api.build_path('scripts', 'slave', 'gatekeeper_launch.py')])

+ ]

« no previous file with comments | « scripts/slave/recipe_util.py ('k') | scripts/slave/recipes/run_presubmit.py » ('j') | no next file with comments »