scripts/slave/recipes_test/run_presubmit.blink_bare.expected - Issue 15270004: Add step generator protocol, remove annotated_checkout, remove script.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes_test/run_presubmit.blink_bare.expected

Issue 15270004: Add step generator protocol, remove annotated_checkout, remove script. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Address comments and change expected json output format Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": ["[DEPOT_TOOLS_ROOT]/gclient", "config", "--spec", "solutions = [{'url ': 'svn://svn-mirror.golo.chromium.org/blink/trunk', 'safesync_url': '', 'manage d': True, 'name': 'blink', 'deps_file': ''}]\n"],

4 "[DEPOT_TOOLS_ROOT]/apply_issue",	4 "name": "gclient setup",

5 "-r",	5 "seed_steps": ["gclient setup", "gclient clean", "gclient sync"]

6 "[BUILD_ROOT]/slave/fake_slave/build/blink/",	6 },

7 "-i",

8 12853011,

9 "-p",

10 1,

11 "-s",

12 "https://chromiumcodereview.appspot.com",

13 "-e",

14 "commit-bot@chromium.org"

15 ],

16 "name": "apply_issue"

17 },

18 {	7 {

19 "cmd": [	8 "cmd": ["[DEPOT_TOOLS_ROOT]/gclient", "revert", "--nohooks"],

20 "[DEPOT_TOOLS_ROOT]/presubmit_support.py",	9 "name": "gclient clean"

21 "--root",	10 },

22 "[BUILD_ROOT]/slave/fake_slave/build/blink/",	11 {

23 "--commit",	12 "cmd": ["[DEPOT_TOOLS_ROOT]/gclient", "sync", "--nohooks"],

24 "--verbose",	13 "name": "gclient sync"

25 "--verbose",	14 },

26 "--issue",	15 {

27 12853011,	16 "cmd": ["[DEPOT_TOOLS_ROOT]/apply_issue", "-r", "[SLAVE_BUILD_ROOT]/blink/", "-i", 12853011, "-p", 1, "-s", "https://chromiumcodereview.appspot.com", "-e", " commit-bot@chromium.org"],

28 "--patchset",	17 "name": "apply_issue"

29 1,	18 },

30 "--skip_canned",	19 {

31 "CheckRietveldTryJobExecution",	20 "cmd": ["[DEPOT_TOOLS_ROOT]/presubmit_support.py", "--root", "[SLAVE_BUILD_RO OT]/blink/", "--commit", "--verbose", "--verbose", "--issue", 12853011, "--patch set", 1, "--skip_canned", "CheckRietveldTryJobExecution", "--skip_canned", "Chec kTreeIsOpen", "--skip_canned", "CheckBuildbotPendingBuilds", "--rietveld_url", " https://chromiumcodereview.appspot.com", "--rietveld_email", "", "--rietveld_fet ch"],

32 "--skip_canned",	21 "name": "presubmit"

33 "CheckTreeIsOpen",

34 "--skip_canned",

35 "CheckBuildbotPendingBuilds",

36 "--rietveld_url",

37 "https://chromiumcodereview.appspot.com",

38 "--rietveld_email",

39 "",

40 "--rietveld_fetch"

41 ],

42 "name": "presubmit"

43 }	22 }

44 ]	23 ]

OLD	NEW