Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: build/android/buildbot/bb_utils.py

Issue 15261003: Add a new script bb_host_steps.py which handles all host side steps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/buildbot/bb_utils.py
diff --git a/build/android/buildbot/bb_utils.py b/build/android/buildbot/bb_utils.py
new file mode 100644
index 0000000000000000000000000000000000000000..84da226c352594c7be50fd2c38f881f68c915955
--- /dev/null
+++ b/build/android/buildbot/bb_utils.py
@@ -0,0 +1,82 @@
+# Copyright (c) 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import json
+import optparse
+import os
+import pipes
+import subprocess
+import sys
+
+sys.path.append(os.path.join(os.path.dirname(__file__), '..'))
+from pylib import buildbot_report
+from pylib import constants
+
+
+TESTING = 'BUILDBOT_TESTING' in os.environ
+
+BB_BUILD_DIR = os.path.abspath(
+ os.path.join(os.path.dirname(__file__), os.pardir, os.pardir, os.pardir,
+ os.pardir, os.pardir, os.pardir, os.pardir))
+
+GOMA_DIR = os.path.join(BB_BUILD_DIR, 'goma')
Isaac (away) 2013/06/05 03:03:07 remove this variable.
Siva Chandra 2013/06/05 21:04:28 Done.
+
+
+class BBOptionParser(optparse.OptionParser):
+ def Error(self, msg):
+ self.print_help()
+ print >> sys.stderr, '\nERROR:', msg
+ return 1
+
+
+def SpawnCmd(command):
+ """Spawn a process without waiting for termination."""
+ print '>', ' '.join(map(pipes.quote, command))
+ sys.stdout.flush()
+ if TESTING:
+ class MockPopen(object):
+ @staticmethod
+ def wait():
+ return 0
+ return MockPopen()
+
+ return subprocess.Popen(command, cwd=constants.CHROME_DIR)
+
+
+def RunCmd(command, flunk_on_failure=True, halt_on_failure=False,
+ retcode_callback=None):
+ """Run a command relative to the chrome source root."""
+ code = SpawnCmd(command).wait()
+ print '<', ' '.join(map(pipes.quote, command))
+ if retcode_callback:
+ code, flunk_on_failure, halt_on_failure = retcode_callback(code)
Isaac (away) 2013/06/05 03:03:07 I don't think we need this callback - can you pas
Siva Chandra 2013/06/05 21:04:28 Done.
+ if code != 0:
+ print 'ERROR: process exited with code %d' % code
+ if flunk_on_failure:
+ buildbot_report.PrintError()
+ else:
+ buildbot_report.PrintWarning()
+ # Allow steps to have both halting (i.e. 1) and non-halting exit codes.
+ if code != 0 and code != 88 and halt_on_failure:
+ raise OSError()
+ return code
+
+
+def ConvertJson(option, _, value, parser):
+ setattr(parser.values, option.dest, json.loads(value))
+
+
+def GetParser():
+ parser = BBOptionParser()
Isaac (away) 2013/06/05 03:03:07 Actually, I think it would be OK to use a regular
Siva Chandra 2013/06/05 21:04:28 Done.
+ parser.add_option('--build-properties', action='callback',
+ callback=ConvertJson, type='string', default={},
+ help='build properties in JSON format')
+ parser.add_option('--factory-properties', action='callback',
+ callback=ConvertJson, type='string', default={},
+ help='factory properties in JSON format')
+ parser.add_option('--slave-properties', action='callback',
+ callback=ConvertJson, type='string', default={},
+ help='Properties set by slave script in JSON format')
+
+ return parser

Powered by Google App Engine
This is Rietveld 408576698