Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6178)

Unified Diff: chrome/installer/util/chrome_app_host_distribution.cc

Issue 15255004: Refactor of BrowserDistribution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rework Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/chrome_app_host_distribution.cc
diff --git a/chrome/installer/util/chrome_app_host_distribution.cc b/chrome/installer/util/chrome_app_host_distribution.cc
index 4ff30be22cf1e143fefdd357572043675ae11f98..cd5c138306eaba23809bc5645d4f2160ef73a04a 100644
--- a/chrome/installer/util/chrome_app_host_distribution.cc
+++ b/chrome/installer/util/chrome_app_host_distribution.cc
@@ -38,16 +38,15 @@ string16 ChromeAppHostDistribution::GetBaseAppName() {
return L"Google Chrome App Launcher";
}
-string16 ChromeAppHostDistribution::GetAppShortCutName() {
- const string16& product_name =
- installer::GetLocalizedString(IDS_PRODUCT_APP_LAUNCHER_NAME_BASE);
- return product_name;
-}
-
-string16 ChromeAppHostDistribution::GetAlternateApplicationName() {
- const string16& product_name =
- installer::GetLocalizedString(IDS_PRODUCT_APP_LAUNCHER_NAME_BASE);
- return product_name;
+string16 ChromeAppHostDistribution::GetShortcutName(
+ ShortcutEnum shortcut_enum) {
+ switch (shortcut_enum) {
+ case SHORTCUT_APP_LAUNCHER:
+ return installer::GetLocalizedString(IDS_PRODUCT_APP_LAUNCHER_NAME_BASE);
+ default:
+ NOTREACHED();
gab 2013/06/18 19:50:29 As it is, GetDisplayName() will hit this for this
calamity 2013/06/27 01:27:44 Done.
+ return string16();
+ }
}
string16 ChromeAppHostDistribution::GetBaseAppId() {

Powered by Google App Engine
This is Rietveld 408576698