Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5483)

Unified Diff: chrome/installer/util/chrome_frame_distribution.cc

Issue 15255004: Refactor of BrowserDistribution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rework Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/chrome_frame_distribution.cc
diff --git a/chrome/installer/util/chrome_frame_distribution.cc b/chrome/installer/util/chrome_frame_distribution.cc
index 68379d0c78d57d1424eae221f0de2ec4dcefd419..e59234dd382e014d78c9a3b0c784580bc6dc19e1 100644
--- a/chrome/installer/util/chrome_frame_distribution.cc
+++ b/chrome/installer/util/chrome_frame_distribution.cc
@@ -36,16 +36,15 @@ string16 ChromeFrameDistribution::GetBaseAppName() {
return L"Google Chrome Frame";
}
-string16 ChromeFrameDistribution::GetAppShortCutName() {
- const string16& product_name =
- installer::GetLocalizedString(IDS_PRODUCT_FRAME_NAME_BASE);
- return product_name;
-}
-
-string16 ChromeFrameDistribution::GetAlternateApplicationName() {
- const string16& product_name =
- installer::GetLocalizedString(IDS_PRODUCT_FRAME_NAME_BASE);
- return product_name;
+string16 ChromeFrameDistribution::GetShortcutName(ShortcutType shortcut_type) {
+ switch (shortcut_type) {
+ case SHORTCUT_CHROME:
+ case SHORTCUT_ALTERNATE_CHROME:
+ return installer::GetLocalizedString(IDS_PRODUCT_FRAME_NAME_BASE);
+ default:
+ NOTREACHED();
+ return string16();
+ }
}
string16 ChromeFrameDistribution::GetInstallSubDir() {
@@ -112,8 +111,14 @@ string16 ChromeFrameDistribution::GetIconFilename() {
return installer::kChromeExe;
}
-int ChromeFrameDistribution::GetIconIndex() {
- return 0;
+int ChromeFrameDistribution::GetIconIndex(ShortcutType shortcut_type) {
+ switch (shortcut_type) {
+ case SHORTCUT_CHROME:
+ return 0;
+ default:
+ NOTREACHED();
+ return 0;
+ }
}
bool ChromeFrameDistribution::CanSetAsDefault() {

Powered by Google App Engine
This is Rietveld 408576698