chrome/installer/util/chrome_browser_operations.cc - Issue 15255004: Refactor of BrowserDistribution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/chrome_browser_operations.cc

Issue 15255004: Refactor of BrowserDistribution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rework Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/chrome_browser_operations.cc

diff --git a/chrome/installer/util/chrome_browser_operations.cc b/chrome/installer/util/chrome_browser_operations.cc

index 01a106b4cb355bc4c9389a0bd26d765725441bae..c25b0282ced9c0c46d50b73d234e1314c76bba8f 100644

--- a/chrome/installer/util/chrome_browser_operations.cc

+++ b/chrome/installer/util/chrome_browser_operations.cc

@@ -112,7 +112,8 @@ void ChromeBrowserOperations::AddDefaultShortcutProperties(

properties->set_target(target_exe);

if (!properties->has_icon()) {

- int icon_index = dist->GetIconIndex();

+ int icon_index =

+ dist->GetIconIndex(BrowserDistribution::SHORTCUT_CHROME);

base::FilePath prefs_path(target_exe.DirName().AppendASCII(

installer::kDefaultMasterPrefs));

if (file_util::PathExists(prefs_path)) {