Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2825)

Unified Diff: chrome/installer/util/browser_distribution.cc

Issue 15255004: Refactor of BrowserDistribution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/browser_distribution.cc
diff --git a/chrome/installer/util/browser_distribution.cc b/chrome/installer/util/browser_distribution.cc
index 4f711419db140c7338e7eeaeef6331f99c93f301..edcb3ea3fb98893c2c4162e1951556803e1fd770 100644
--- a/chrome/installer/util/browser_distribution.cc
+++ b/chrome/installer/util/browser_distribution.cc
@@ -154,6 +154,10 @@ string16 BrowserDistribution::GetBaseAppName() {
return L"Chromium";
}
+string16 BrowserDistribution::GetDisplayName() {
+ return GetShortcutInfo(SHORTCUT_CHROME).name;
+}
+
string16 BrowserDistribution::GetAppShortCutName() {
return GetBaseAppName();
}
@@ -162,6 +166,38 @@ string16 BrowserDistribution::GetAlternateApplicationName() {
return L"The Internet";
}
+BrowserDistribution::ShortcutInfo BrowserDistribution::GetShortcutInfo(
+ ShortcutEnum shortcut_enum) {
+ ShortcutInfo info;
+ switch (shortcut_enum) {
+ case SHORTCUT_CHROME:
+ info.name = GetAppShortCutName();
+ info.icon_index = GetIconIndex();
+ info.icon_file = GetIconFilename();
+ break;
+ case SHORTCUT_ALTERNATE_CHROME:
+ info.name = GetAlternateApplicationName();
+ info.icon_index = GetIconIndex();
+ info.icon_file = GetIconFilename();
+ break;
+ default:
+ NOTREACHED();
+ }
+ return info;
+}
+
+string16 BrowserDistribution::GetStartMenuShortcutSubfolder(
+ SubfolderEnum subfolder_enum) {
+ switch (subfolder_enum) {
+ case SUBFOLDER_CHROME:
+ return GetShortcutInfo(SHORTCUT_CHROME).name;
+ break;
+ default:
+ NOTREACHED();
+ return string16();
+ }
+}
+
string16 BrowserDistribution::GetBaseAppId() {
return L"Chromium";
}
@@ -265,3 +301,7 @@ bool BrowserDistribution::ShouldSetExperimentLabels() {
bool BrowserDistribution::HasUserExperiments() {
return false;
}
+
+int BrowserDistribution::GetAppListIconIndex() {
+ return 1;
+}

Powered by Google App Engine
This is Rietveld 408576698