Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 15255002: Files.app: Remove unused private API "chrome.fileBrowserPrivate.getFileLocations". (Closed)

Created:
7 years, 7 months ago by yoshiki
Modified:
7 years, 7 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Files.app: Remove unused private API "chrome.fileBrowserPrivate.getFileLocations". "getFileLocations" is not used anywhere. We can remove it. BUG=241695 TEST=Files.app Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -79 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc View 2 chunks +0 lines, -37 lines 0 comments Download
M chrome/browser/extensions/extension_function_histogram_value.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/file_browser_private.json View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtomasz
lgtm
7 years, 7 months ago (2013-05-17 06:24:50 UTC) #1
yoshiki
+satorux, mpcomplete: Could you take a look? Thanks. @satorux: chrome/browser/chromeos/extensions/file_manager/* @mpcomplete: - chrome/browser/extensions/extension_function_histogram_value.h - chrome/common/extensions/api/file_browser_private.json
7 years, 7 months ago (2013-05-17 06:30:22 UTC) #2
satorux1
LGTM. Thank you for removing the obsolete private API
7 years, 7 months ago (2013-05-17 07:08:50 UTC) #3
yoshiki
@benwells: Could you take an OWNER-look at following files on behalf of mpcomplete? - chrome/browser/extensions/extension_function_histogram_value.h ...
7 years, 7 months ago (2013-05-17 07:44:51 UTC) #4
Matt Perry
lgtm
7 years, 7 months ago (2013-05-17 18:58:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/15255002/1
7 years, 7 months ago (2013-05-17 18:58:30 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-17 22:56:51 UTC) #7
Message was sent while issue was closed.
Change committed as 200915

Powered by Google App Engine
This is Rietveld 408576698