Handle unexpected entity fields gracefully.

Handle unexpected entity fields gracefully.

Introduces a new field type 'extra', which allows full control over what to do
with the extra properties, instead of having all operations return unhelpful
conversion error messages.

This allows black-holes, schema upgrades and 'expando' style mixed
structured/unstructured objects. Please see the tests for usage and examples.

R=dnj@chromium.org, estaab@chromium.org, vadimsh@chromium.org
BUG=https://github.com/luci/gae/issues/13

Committed: https://github.com/luci/gae/commit/d26455b74be21a3f1ab72e2eb9088039f1191ad6

[dnj, 2015-12-12 20:18:34]

lgtm

https://chromiumcodereview.appspot.com/1525453002/diff/1/service/datastore/da...
File service/datastore/datastore_test.go (right):

https://chromiumcodereview.appspot.com/1525453002/diff/1/service/datastore/da...
service/datastore/datastore_test.go:1093: b := &BlackHole{ID: 10, NewStuff:
"amazeballs"}
(╯°□°)╯︵ ┻━┻

[iannucci, 2015-12-12 21:14:42]

https://codereview.chromium.org/1525453002/diff/1/service/datastore/datastore...
File service/datastore/datastore_test.go (right):

https://codereview.chromium.org/1525453002/diff/1/service/datastore/datastore...
service/datastore/datastore_test.go:1093: b := &BlackHole{ID: 10, NewStuff:
"amazeballs"}
On 2015/12/12 at 20:18:34, dnj wrote:
> (╯°□°)╯︵ ┻━┻

good point. done.

[iannucci, 2015-12-12 21:14:53]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2015-12-12 21:14:54]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org
Link to the patchset: https://codereview.chromium.org/1525453002/#ps20001
(title: "fix nit")

[commit-bot: I haz the power, 2015-12-12 21:15:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1525453002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1525453002/20001

[commit-bot: I haz the power, 2015-12-12 21:17:55]

Description was changed from

==========
Handle unexpected entity fields gracefully.

Introduces a new field type 'extra', which allows full control over what to do
with the extra properties, instead of having all operations return unhelpful
conversion error messages.

This allows black-holes, schema upgrades and 'expando' style mixed
structured/unstructured objects. Please see the tests for usage and examples.

R=dnj@chromium.org, estaab@chromium.org, vadimsh@chromium.org
BUG=https://github.com/luci/gae/issues/13
==========

to

==========
Handle unexpected entity fields gracefully.

Introduces a new field type 'extra', which allows full control over what to do
with the extra properties, instead of having all operations return unhelpful
conversion error messages.

This allows black-holes, schema upgrades and 'expando' style mixed
structured/unstructured objects. Please see the tests for usage and examples.

R=dnj@chromium.org, estaab@chromium.org, vadimsh@chromium.org
BUG=https://github.com/luci/gae/issues/13

Committed:
https://github.com/luci/gae/commit/d26455b74be21a3f1ab72e2eb9088039f1191ad6
==========

[commit-bot: I haz the power, 2015-12-12 21:17:56]

Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/d26455b74be21a3f1ab72e2eb9088039f1191ad6

[dnj (Google), 2015-12-13 02:09:23]

dnj@google.com changed reviewers:
+ dnj@google.com

[dnj (Google), 2015-12-13 02:09:24]

https://codereview.chromium.org/1525453002/diff/1/service/datastore/datastore...
File service/datastore/datastore_test.go (right):

https://codereview.chromium.org/1525453002/diff/1/service/datastore/datastore...
service/datastore/datastore_test.go:1093: b := &BlackHole{ID: 10, NewStuff:
"amazeballs"}
On 2015/12/12 21:14:42, iannucci wrote:
> On 2015/12/12 at 20:18:34, dnj wrote:
> > (╯°□°)╯︵ ┻━┻
> 
> good point. done.

+1