Cross-platform DefaultThemeProvider.

Cross-platform DefaultThemeProvider.

Not yet used as default for all windows on OSX, since some code treats ThemeService/ThemeProvider as interchangeable.

BUG=241908
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202283

[groby-ooo-7-16, 2013-05-17 02:35:14]

As discussed with sail@, rsesek@, thakis@, adding a DefaultThemeProvider for
Mac. 

Making it available to other platforms too, while I'm here.

PTAL.

ben:General sanity check for cross platform + ui & views review
rsesek:Cocoa review.

[groby-ooo-7-16, 2013-05-17 02:35:52]

CC'd thakis

[groby-ooo-7-16, 2013-05-17 03:59:02]

Turns out that many places on the Mac happily cast ThemeProvider->ThemeService. 
Digging further in that direction, but that obviously means no rush on reviewing
this CL :(

[Robert Sesek, 2013-05-17 14:06:36]

This looks about right, though I'll let you sort out the ThemeService issue
before approving.

Separate from what you're doing in this CL, it looks like the ThemeProvider
interface could be simplified a little bit by using gfx::Image instead of
#ifdefs for the platform types.

https://codereview.chromium.org/15240002/diff/9001/chrome/browser/ui/cocoa/th...
File chrome/browser/ui/cocoa/themed_window.mm (right):

https://codereview.chromium.org/15240002/diff/9001/chrome/browser/ui/cocoa/th...
chrome/browser/ui/cocoa/themed_window.mm:12: // Whether to allow NSExceptions to
be raised on the current thread.
?

[Ben Goodger (Google), 2013-05-17 19:49:50]

lgtm for moving out of views

[groby-ooo-7-16, 2013-05-17 23:52:57]

OK, not making DefaultThemeProvider the default since there are several issues
to be resolved first - tracking under http://crbug.com/241908

Comment re: gfx::Image filed under http://crbug.com/241946

rsesek: OK to land, then?
ben: Still good with the move, even if it is currently only used under views?

https://chromiumcodereview.appspot.com/15240002/diff/9001/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/themed_window.mm (right):

https://chromiumcodereview.appspot.com/15240002/diff/9001/chrome/browser/ui/c...
chrome/browser/ui/cocoa/themed_window.mm:12: // Whether to allow NSExceptions to
be raised on the current thread.
Overzealous copy/paste on a late night :(
On 2013/05/17 14:06:37, rsesek wrote:
> ?

[Robert Sesek, 2013-05-20 16:33:25]

LGTM

And can you please update the CL description.

https://chromiumcodereview.appspot.com/15240002/diff/18001/ui/base/default_th...
File ui/base/default_theme_provider_mac.mm (right):

https://chromiumcodereview.appspot.com/15240002/diff/18001/ui/base/default_th...
ui/base/default_theme_provider_mac.mm:7: #import <Cocoa/Cocoa.h>
nit: blank line after

[groby-ooo-7-16, 2013-05-25 00:45:37]

https://chromiumcodereview.appspot.com/15240002/diff/18001/ui/base/default_th...
File ui/base/default_theme_provider_mac.mm (right):

https://chromiumcodereview.appspot.com/15240002/diff/18001/ui/base/default_th...
ui/base/default_theme_provider_mac.mm:7: #import <Cocoa/Cocoa.h>
On 2013/05/20 16:33:25, rsesek wrote:
> nit: blank line after

Done.

[commit-bot: I haz the power, 2013-05-25 00:46:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/15240002/28001

[commit-bot: I haz the power, 2013-05-25 03:18:59]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-25 04:08:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/15240002/28001

[commit-bot: I haz the power, 2013-05-25 14:20:48]

Change committed as 202283