Source/core/html/HTMLAnchorElement.cpp - Issue 15238002: Disallow tabsToLinks setting to prevent tabbing to anchor with tabIndex.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLAnchorElement.cpp

Issue 15238002: Disallow tabsToLinks setting to prevent tabbing to anchor with tabIndex. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: And update expected result after removing accidentally added line Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLAnchorElement.cpp

diff --git a/Source/core/html/HTMLAnchorElement.cpp b/Source/core/html/HTMLAnchorElement.cpp

index 5fa5a2b23b2b4897a611a042d475cf9f94e4c652..43ee0a17952067dda10ab4ada869d4649d81f2a6 100644

--- a/Source/core/html/HTMLAnchorElement.cpp

+++ b/Source/core/html/HTMLAnchorElement.cpp

@@ -163,6 +163,9 @@ bool HTMLAnchorElement::isMouseFocusable() const

bool HTMLAnchorElement::isKeyboardFocusable() const

{

+ if (isFocusable() && Element::supportsFocus())

+ return HTMLElement::isKeyboardFocusable();

if (isLink()) {

Page* page = document().page();

if (!page)

« no previous file with comments | « LayoutTests/fast/events/tab-focus-anchor-tab-to-links-expected.txt ('k') | no next file » | no next file with comments »