Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1294)

Side by Side Diff: Source/WebKit/chromium/src/InbandTextTrackPrivateImpl.cpp

Issue 15236002: WebInbandTextTrack should be deallocated by caller (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/WebKit/chromium/src/InbandTextTrackPrivateImpl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 14 matching lines...) Expand all
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "InbandTextTrackPrivateImpl.h" 31 #include "InbandTextTrackPrivateImpl.h"
32 #include "WebInbandTextTrack.h" 32 #include "WebInbandTextTrack.h"
33 #include "core/platform/graphics/InbandTextTrackPrivateClient.h" 33 #include "core/platform/graphics/InbandTextTrackPrivateClient.h"
34 #include "public/WebString.h" 34 #include "public/WebString.h"
35 #include <wtf/PassOwnPtr.h>
36 35
37 namespace WebKit { 36 namespace WebKit {
38 37
39 InbandTextTrackPrivateImpl::InbandTextTrackPrivateImpl(WebInbandTextTrack* track ) 38 InbandTextTrackPrivateImpl::InbandTextTrackPrivateImpl(WebInbandTextTrack* track )
40 : m_track(adoptPtr(track)) 39 : m_track(track)
41 { 40 {
42 ASSERT(track); 41 ASSERT(track);
43 track->setClient(this); 42 track->setClient(this);
44 } 43 }
45 44
46 InbandTextTrackPrivateImpl::~InbandTextTrackPrivateImpl() 45 InbandTextTrackPrivateImpl::~InbandTextTrackPrivateImpl()
47 { 46 {
48 m_track->setClient(0); 47 m_track->setClient(0);
49 } 48 }
50 49
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 double start, 96 double start,
98 double end, 97 double end,
99 const WebString& id, 98 const WebString& id,
100 const WebString& content, 99 const WebString& content,
101 const WebString& settings) 100 const WebString& settings)
102 { 101 {
103 client()->addWebVTTCue(this, start, end, id, content, settings); 102 client()->addWebVTTCue(this, start, end, id, content, settings);
104 } 103 }
105 104
106 } // namespace WebKit 105 } // namespace WebKit
OLDNEW
« no previous file with comments | « Source/WebKit/chromium/src/InbandTextTrackPrivateImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698