Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 15231006: [Android] Fix proguard (Closed)

Created:
7 years, 7 months ago by cjhopman
Modified:
7 years, 7 months ago
Reviewers:
shashi, Yaron
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] Fix proguard Gyp supports only very limited ways of changing behavior based upon CONFIGURATION_NAME. Particularly, it does not support the way that was supposed to enable/disable use of proguard. Instead of trying to switch behavior in gyp, instead pass CONFIGURATION_NAME, proguard_enabled, and proguard_enabled_dex_input_path to dex.py and switch the behavior there. This also extracts the dex actions into build/android/dex_action.gypi and uses that for the actions in both build/java.gypi and build/java_apk.gypi. BUG=240837 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200958

Patch Set 1 #

Patch Set 2 : Add help messages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -53 lines) Patch
A build/android/dex_action.gypi View 1 chunk +61 lines, -0 lines 0 comments Download
M build/android/gyp/dex.py View 1 2 chunks +10 lines, -0 lines 0 comments Download
M build/java.gypi View 1 chunk +5 lines, -21 lines 0 comments Download
M build/java_apk.gypi View 1 chunk +8 lines, -32 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
cjhopman
7 years, 7 months ago (2013-05-17 00:54:41 UTC) #1
shashi
lgtm Please verify that size of classes.dex in the apk is reduced on release. I ...
7 years, 7 months ago (2013-05-17 01:22:10 UTC) #2
cjhopman
7 years, 7 months ago (2013-05-17 17:31:36 UTC) #3
Yaron
lgtm
7 years, 7 months ago (2013-05-17 18:04:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/15231006/4001
7 years, 7 months ago (2013-05-17 18:06:20 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=150472
7 years, 7 months ago (2013-05-17 20:57:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/15231006/4001
7 years, 7 months ago (2013-05-17 21:03:26 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-18 02:33:41 UTC) #8
Message was sent while issue was closed.
Change committed as 200958

Powered by Google App Engine
This is Rietveld 408576698