impl/memory/datastore_test.go - Issue 1521823003: Clean up callback interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: impl/memory/datastore_test.go

Issue 1521823003: Clean up callback interfaces. (Closed) Base URL: https://github.com/luci/gae.git@extra

Patch Set: fixins Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: impl/memory/datastore_test.go

diff --git a/impl/memory/datastore_test.go b/impl/memory/datastore_test.go

index 269b5dea2100fd48e4e06137a341bf57dad8f742..2f22e3dedc72c2fee1e1de93ec3cff256c3eeada 100644

--- a/impl/memory/datastore_test.go

+++ b/impl/memory/datastore_test.go

@@ -100,9 +100,10 @@ func TestDatastoreSingleReadWriter(t *testing.T) {

}

So(ds.DeleteMulti(keys), ShouldBeNil)

count := 0

- So(ds.Raw().DeleteMulti(keys, func(err error) {

+ So(ds.Raw().DeleteMulti(keys, func(err error) error {

count++

So(err, ShouldBeNil)

+ return nil

}), ShouldBeNil)

So(count, ShouldEqual, len(keys))

})

@@ -129,9 +130,8 @@ func TestDatastoreSingleReadWriter(t *testing.T) {

ds.Testable().CatchupIndexes()

count := 0

- So(ds.Run(dsS.NewQuery(""), func(_ *dsS.Key, _ dsS.CursorCB) bool {

+ So(ds.Run(dsS.NewQuery(""), func(_ *dsS.Key) {

count++

- return true

}), ShouldBeNil)

So(count, ShouldEqual, 3)

« no previous file with comments | « impl/memory/datastore_query_execution_test.go ('k') | impl/memory/gkvlite_iter.go » ('j') | no next file with comments »