Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4815)

Unified Diff: chrome/browser/ssl/ssl_add_certificate.cc

Issue 1520543004: Add method for identifying different InfoBars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit again Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_add_certificate.cc
diff --git a/chrome/browser/ssl/ssl_add_certificate.cc b/chrome/browser/ssl/ssl_add_certificate.cc
index 312b663bab29b1f562e8f24a03c4d4d0fce8b008..97117f45d967fc5c07535011cdcdf7f2eb56fb1a 100644
--- a/chrome/browser/ssl/ssl_add_certificate.cc
+++ b/chrome/browser/ssl/ssl_add_certificate.cc
@@ -13,6 +13,7 @@
#include "chrome/grit/generated_resources.h"
#include "components/infobars/core/confirm_infobar_delegate.h"
#include "components/infobars/core/infobar.h"
+#include "components/infobars/core/infobar_delegate.h"
#include "components/infobars/core/simple_alert_infobar_delegate.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/render_frame_host.h"
@@ -45,6 +46,7 @@ class SSLAddCertificateInfoBarDelegate : public ConfirmInfoBarDelegate {
// ConfirmInfoBarDelegate:
Type GetInfoBarType() const override;
+ infobars::InfoBarDelegate::InfoBarIdentifier GetIdentifier() const override;
int GetIconId() const override;
gfx::VectorIconId GetVectorIconId() const override;
base::string16 GetMessageText() const override;
@@ -79,6 +81,11 @@ SSLAddCertificateInfoBarDelegate::GetInfoBarType() const {
return PAGE_ACTION_TYPE;
}
+infobars::InfoBarDelegate::InfoBarIdentifier
+SSLAddCertificateInfoBarDelegate::GetIdentifier() const {
+ return SSL_ADD_CERTIFICATE_INFOBAR_DELEGATE;
+}
+
int SSLAddCertificateInfoBarDelegate::GetIconId() const {
// TODO(davidben): Use a more appropriate icon.
return IDR_INFOBAR_SAVE_PASSWORD;
@@ -131,7 +138,9 @@ void ShowErrorInfoBar(int message_id,
// TODO(davidben): Use a more appropriate icon.
// TODO(davidben): Display a more user-friendly error string.
SimpleAlertInfoBarDelegate::Create(
- InfoBarService::FromWebContents(web_contents), IDR_INFOBAR_SAVE_PASSWORD,
+ InfoBarService::FromWebContents(web_contents),
+ infobars::InfoBarDelegate::SSL_ADD_CERTIFICATE,
+ IDR_INFOBAR_SAVE_PASSWORD,
#if !defined(OS_MACOSX)
gfx::VectorIconId::AUTOLOGIN,
#else

Powered by Google App Engine
This is Rietveld 408576698