Add method for identifying different InfoBars

chrome/browser/devtools/global_confirm_info_bar.cc

Index: chrome/browser/devtools/global_confirm_info_bar.cc
diff --git a/chrome/browser/devtools/global_confirm_info_bar.cc b/chrome/browser/devtools/global_confirm_info_bar.cc
index 1a88612b17337d43cf6cdce75c20b02f568afefb..5139147cae855edd6a854d0341f909f06be17376 100644
--- a/chrome/browser/devtools/global_confirm_info_bar.cc
+++ b/chrome/browser/devtools/global_confirm_info_bar.cc
@@ -25,6 +25,7 @@ class GlobalConfirmInfoBar::DelegateProxy : public ConfirmInfoBarDelegate {
   friend class GlobalConfirmInfoBar;
 
   // ConfirmInfoBarDelegate overrides
+  infobars::InfoBarDelegate::InfoBarIdentifier GetIdentifier() const override;
   base::string16 GetMessageText() const override;
   int GetButtons() const override;
   base::string16 GetButtonLabel(InfoBarButton button) const override;
@@ -51,6 +52,12 @@ GlobalConfirmInfoBar::DelegateProxy::DelegateProxy(
 GlobalConfirmInfoBar::DelegateProxy::~DelegateProxy() {
 }
 
+infobars::InfoBarDelegate::InfoBarIdentifier
+GlobalConfirmInfoBar::DelegateProxy::GetIdentifier() const {
+  return global_info_bar_ ? global_info_bar_->delegate_->GetIdentifier()
+                          : INVALID_ID;

[Peter Kasting, 2015/12/30 01:52:57]

Uggghhhh.  This really shouldn't be needed; I don't think the design of this
class is correct at all.  I filed bug 573088 against myself to understand and
fix up this code.

I'm inclined to suggest that we make INVALID_ID -1 and add a DCHECK in
InfoBarContainer::AddInfoBar() that we don't get this value there (which we
never should, even with this code existing); then I can later rip this out
entirely without leaving a hole at the beginning of the histogram.

I don't just want this for cleanliness; I worry that if we leave this value,
someone later will try to use it for some kind of "infobar that I don't care
about collecting metrics on" and I don't want to leave that possibility.

[gone, 2015/12/30 07:29:03]

Yeah, when I hit this I was a bit confused about why the class was written as it
was.  I've added a DCHECK and changed the INVALID value to -1.  Thanks for
looking into it.

+}
+
 base::string16 GlobalConfirmInfoBar::DelegateProxy::GetMessageText() const {
   return global_info_bar_ ? global_info_bar_->delegate_->GetMessageText()
                           : base::string16();