Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: components/infobars/core/infobar_delegate.h

Issue 1520543004: Add method for identifying different InfoBars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reverting Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/infobars/core/infobar_delegate.h
diff --git a/components/infobars/core/infobar_delegate.h b/components/infobars/core/infobar_delegate.h
index bed797f461274d2990cb5e3fe4679f14cd21b819..e7fd9b56debf98387ed528fdebd706b7f89ba481 100644
--- a/components/infobars/core/infobar_delegate.h
+++ b/components/infobars/core/infobar_delegate.h
@@ -83,6 +83,12 @@ class InfoBarDelegate {
// as background color) of the infobar.
virtual Type GetInfoBarType() const;
+ // Returns a unique string identifying the infobar.
+ // Implementers must update the InfoBarType enum in histograms.xml, with the
Peter Kasting 2015/12/16 21:02:46 Nit: No comma
gone 2015/12/16 22:53:11 Done.
+ // string provided by this function as the key and
+ // base::HashMetricName(string) as its value.
+ virtual std::string GetIdentifier() const = 0;
+
virtual InfoBarAutomationType GetInfoBarAutomationType() const;
// Returns the resource ID of the icon to be shown for this InfoBar. If the
« no previous file with comments | « components/infobars/core/infobar_container.cc ('k') | components/infobars/core/simple_alert_infobar_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698