Add method for identifying different InfoBars

components/infobars/core/simple_alert_infobar_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/infobars/core/simple_alert_infobar_delegate.h"
 
 #include "components/infobars/core/infobar.h"
 #include "components/infobars/core/infobar_manager.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 
 // static
 void SimpleAlertInfoBarDelegate::Create(
     infobars::InfoBarManager* infobar_manager,
+    infobars::InfoBarDelegate::InfoBarIdentifier infobar_identifier,
     int icon_id,
     gfx::VectorIconId vector_icon_id,
     const base::string16& message,
     bool auto_expire) {
   infobar_manager->AddInfoBar(infobar_manager->CreateConfirmInfoBar(
       scoped_ptr<ConfirmInfoBarDelegate>(new SimpleAlertInfoBarDelegate(
-          icon_id, vector_icon_id, message, auto_expire))));
+          infobar_identifier, icon_id, vector_icon_id, message, auto_expire))));
 }
 
 SimpleAlertInfoBarDelegate::SimpleAlertInfoBarDelegate(
+    infobars::InfoBarDelegate::InfoBarIdentifier infobar_identifier,
     int icon_id,
     gfx::VectorIconId vector_icon_id,
     const base::string16& message,
     bool auto_expire)
     : ConfirmInfoBarDelegate(),
+      infobar_identifier_(infobar_identifier),

[Peter Kasting, 2015/12/30 01:52:57]

I realized while reviewing this that we could avoid this member if, instead of
adding GetIdentifier(), we implemented this change by passing the enum value
directly to AddInfoBar().  That would result in this CL touching half as many
places (since we wouldn't need to update class declarations in header files). 
However, that would preclude the possibility of reimplementing some of the
existing methods (e.g. GetInfoBarType() as switch statements in a non-virtual
base class function.  So it's probably better to keep things as you have them.

[gone, 2015/12/30 07:29:03]

Huh, that would have definitely made sense for this CL.  I agree that's probably
better to leave it as is, though, since it'll make future potential changes
easier.  I could imagine new metrics being thought up once UX starts
getting some of this data in, e.g., and we'd end up having to do this anyway.

       icon_id_(icon_id),
       vector_icon_id_(vector_icon_id),
       message_(message),
       auto_expire_(auto_expire) {}
 
 SimpleAlertInfoBarDelegate::~SimpleAlertInfoBarDelegate() {
 }
 
+infobars::InfoBarDelegate::InfoBarIdentifier
+SimpleAlertInfoBarDelegate::GetIdentifier() const {
+  return infobar_identifier_;
+}
+
 int SimpleAlertInfoBarDelegate::GetIconId() const {
   return icon_id_;
 }
 
 gfx::VectorIconId SimpleAlertInfoBarDelegate::GetVectorIconId() const {
   return vector_icon_id_;
 }
 
 bool SimpleAlertInfoBarDelegate::ShouldExpire(
     const NavigationDetails& details) const {
   return auto_expire_ && ConfirmInfoBarDelegate::ShouldExpire(details);
 }
 
 base::string16 SimpleAlertInfoBarDelegate::GetMessageText() const {
   return message_;
 }
 
 int SimpleAlertInfoBarDelegate::GetButtons() const {
   return BUTTON_NONE;
 }