Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: content/common/sandbox_linux/sandbox_linux.cc

Issue 1519753002: Linux Sandbox: make renderers dumpable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/sandbox_linux/sandbox_linux.cc
diff --git a/content/common/sandbox_linux/sandbox_linux.cc b/content/common/sandbox_linux/sandbox_linux.cc
index 3f599a8fbe11db62246a05f547e5e392edd8f11e..59ef1760d6fc2528defd412681fc3fe688fb096c 100644
--- a/content/common/sandbox_linux/sandbox_linux.cc
+++ b/content/common/sandbox_linux/sandbox_linux.cc
@@ -28,7 +28,6 @@
#include "base/sys_info.h"
#include "base/time/time.h"
#include "build/build_config.h"
-#include "content/common/sandbox_linux/sandbox_debug_handling_linux.h"
#include "content/common/sandbox_linux/sandbox_linux.h"
#include "content/common/sandbox_linux/sandbox_seccomp_bpf_linux.h"
#include "content/public/common/content_switches.h"
@@ -185,10 +184,6 @@ void LinuxSandbox::EngageNamespaceSandbox() {
std::vector<sandbox::Credentials::Capability> caps;
caps.push_back(sandbox::Credentials::Capability::SYS_ADMIN);
CHECK(sandbox::Credentials::SetCapabilities(proc_fd_, caps));
-
- // This needs to happen after moving to a new user NS, since doing so involves
- // writing the UID/GID map.
- CHECK(SandboxDebugHandling::SetDumpableStatusAndHandlers());
rickyz (no longer on Chrome) 2015/12/11 02:04:44 Do we care about the crash test handler that insta
jln (very slow on Chromium) 2015/12/11 17:53:43 Yeah, it's kind of ugly, but one can always pass -
}
std::vector<int> LinuxSandbox::GetFileDescriptorsToClose() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698