Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7372)

Unified Diff: chrome/browser/search_engines/search_terms_data.h

Issue 151813002: Adds InstantExtendedEnabledParam to the search request URL iff the query extraction flag is enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/search/search_unittest.cc ('k') | chrome/browser/search_engines/search_terms_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search_engines/search_terms_data.h
diff --git a/chrome/browser/search_engines/search_terms_data.h b/chrome/browser/search_engines/search_terms_data.h
index afa09d890c6590099e172254b908f2c005e6bcca..28f45727a371ed08cc4dfecb4380f2c73a5bb19e 100644
--- a/chrome/browser/search_engines/search_terms_data.h
+++ b/chrome/browser/search_engines/search_terms_data.h
@@ -61,12 +61,6 @@ class SearchTermsData {
// the returned string to be non-empty.
virtual std::string ForceInstantResultsParam(bool for_prerender) const;
- // Returns a string indicating whether InstantExtended is enabled, suitable
- // for adding as a query string param to the homepage or search requests.
- // Returns an empty string otherwise. Determining this requires accessing the
- // Profile, so this can only ever be non-empty for UIThreadSearchTermsData.
- virtual std::string InstantExtendedEnabledParam() const;
-
// Returns a string indicating whether a non-default theme is active,
// suitable for adding as a query string param to the homepage. This only
// applies if Instant Extended is enabled. Returns an empty string otherwise.
@@ -82,8 +76,7 @@ class SearchTermsData {
class UIThreadSearchTermsData : public SearchTermsData {
public:
// If |profile_| is NULL, the Google base URL accessors will return default
- // values, and ForceInstantResultsParam(), InstantExtendedEnabledParam(), and
- // NTPIsThemedParam(), will return the empty string.
+ // values, and NTPIsThemedParam() will return an empty string.
explicit UIThreadSearchTermsData(Profile* profile);
virtual std::string GoogleBaseURLValue() const OVERRIDE;
@@ -94,7 +87,6 @@ class UIThreadSearchTermsData : public SearchTermsData {
virtual std::string GetSuggestRequestIdentifier() const OVERRIDE;
virtual std::string ForceInstantResultsParam(
bool for_prerender) const OVERRIDE;
- virtual std::string InstantExtendedEnabledParam() const OVERRIDE;
virtual std::string NTPIsThemedParam() const OVERRIDE;
// Used by tests to override the value for the Google base URL. Passing the
« no previous file with comments | « chrome/browser/search/search_unittest.cc ('k') | chrome/browser/search_engines/search_terms_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698