Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15179002: Remove code that is unused after ContextMenu cleanup (Closed)

Created:
7 years, 7 months ago by adamk
Modified:
7 years, 7 months ago
CC:
blink-reviews, jamesr, caseq+blink_chromium.org, Nate Chapin, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, abarth_chromum.org, lushnikov+blink_chromium.org, yurys+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, gavinp+loader_chromium.org, jchaffraix+rendering, leviw+renderwatch, aandrey+blink_chromium.org, groby-ooo-7-16
Visibility:
Public.

Description

Remove code that is unused after ContextMenu cleanup R=darin Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150384

Patch Set 1 #

Patch Set 2 : Remove canHandleRequest code from DRT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -461 lines) Patch
M Source/WebKit/chromium/public/WebFrameClient.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/public/WebSettings.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/src/FrameLoaderClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/WebKit/chromium/src/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebSettingsImpl.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/editing/Editor.h View 3 chunks +0 lines, -13 lines 0 comments Download
M Source/core/editing/Editor.cpp View 5 chunks +0 lines, -123 lines 0 comments Download
M Source/core/editing/TextCheckingHelper.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/editing/TextCheckingHelper.cpp View 1 chunk +0 lines, -93 lines 0 comments Download
M Source/core/history/BackForwardController.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/history/BackForwardController.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorController.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorController.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/Page.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/Page.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/page/Settings.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/page/Settings.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/HitTestResult.h View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 4 chunks +0 lines, -126 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp View 1 1 chunk +0 lines, -8 lines 0 comments Download
M Tools/DumpRenderTree/chromium/WebViewHost.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Tools/DumpRenderTree/chromium/WebViewHost.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
adamk
7 years, 7 months ago (2013-05-14 21:42:17 UTC) #1
adamk
Note that this change depends on https://codereview.chromium.org/14795011/
7 years, 7 months ago (2013-05-14 21:43:19 UTC) #2
darin (slow to review)
LGTM
7 years, 7 months ago (2013-05-14 22:46:18 UTC) #3
darin (slow to review)
LGTM for DRT cleanup too
7 years, 7 months ago (2013-05-14 22:53:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/15179002/4001
7 years, 7 months ago (2013-05-14 23:41:49 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-15 01:24:40 UTC) #6
Message was sent while issue was closed. 
Change committed as 150384

Powered by Google App Engine
This is Rietveld 408576698