Issue 15178010: Remove ENABLE_ENCRYPTED_MEDIA #define as it's always enabled

Issue 15178010: Remove ENABLE_ENCRYPTED_MEDIA #define as it's always enabled (Closed)

Created:
7 years, 7 months ago by adamk

Modified:
7 years, 7 months ago

Reviewers:
eseidel

CC:
blink-reviews, jamesr, jsbell+bindings_chromium.org, Rik, eae+blinkwatch, abarth-chromium, danakj, feature-media-reviews_chromium.org, dglazkov+blink, pdr., adamk+blink_chromium.org, haraken, Stephen Chennney, Nate Chapin, jeez, vcarbune.chromium, ddorwin, eseidel

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove ENABLE_ENCRYPTED_MEDIA #define as it's always enabled Removing this #define simplifies some MediaPlayer code. The code is still behind a runtime flag. This leaves ENABLE_ENCRYPTED_MEDIA_V2, which is turned off, untouched. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150408

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -128 lines)			Patch
M	Source/WebKit/chromium/src/AssertMatchingEnums.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp	View	4 chunks	+0 lines, -37 lines	0 comments	Download
M	Source/bindings/v8/Dictionary.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/bindings/v8/Dictionary.cpp	View	4 chunks	+1 line, -6 lines	0 comments	Download
M	Source/core/dom/EventNames.in	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/features.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLMediaElement.h	View	3 chunks	+0 lines, -6 lines	0 comments	Download
M	Source/core/html/HTMLMediaElement.cpp	View	6 chunks	+0 lines, -7 lines	0 comments	Download
M	Source/core/html/HTMLMediaElement.idl	View	3 chunks	+1 line, -10 lines	0 comments	Download
M	Source/core/html/MediaError.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	Source/core/html/MediaError.idl	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/html/MediaKeyError.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	Source/core/html/MediaKeyError.idl	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/MediaKeyEvent.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	Source/core/html/MediaKeyEvent.cpp	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/core/html/MediaKeyEvent.idl	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/page/RuntimeEnabledFeatures.in	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/platform/graphics/MediaPlayer.h	View	5 chunks	+0 lines, -10 lines	0 comments	Download
M	Source/core/platform/graphics/MediaPlayer.cpp	View	7 chunks	+0 lines, -17 lines	0 comments	Download
M	Source/core/platform/graphics/MediaPlayerPrivate.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/testing/MockCDM.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/15178010/1

7 years, 7 months ago (2013-05-15 00:50:10 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=5519

7 years, 7 months ago (2013-05-15 02:14:22 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/15178010/1

7 years, 7 months ago (2013-05-15 02:37:33 UTC) #5

Message was sent while issue was closed.

Change committed as 150408

Expand Messages | Collapse Messages