Issue 15178008: Factor out icon ID logic in WebsiteSettingsUI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15178008: Factor out icon ID logic in WebsiteSettingsUI (Closed)

Created:
7 years, 7 months ago by gone

Modified:
7 years, 7 months ago

Reviewers:
markusheintz_

CC:
chromium-reviews, markusheintz_

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Factor out icon ID logic in WebsiteSettingsUI The Android port needs to have access to the IDs of the resources that are being shown instead of the direct Bitmaps so that it can show the correct resources in the UI. BUG=238668, 237034 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200433

Patch Set 1 #

Patch Set 2 : Comment update #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -11 lines)			Patch
	M	chrome/browser/ui/website_settings/website_settings_ui.h	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/website_settings/website_settings_ui.cc	View		4 chunks	+34 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/15178008/2001

7 years, 7 months ago (2013-05-15 19:26:40 UTC) #3

Message was sent while issue was closed.

Change committed as 200433

Expand Messages | Collapse Messages