Issue 15178007: Add runtime flag for PagePopup.

Issue 15178007: Add runtime flag for PagePopup. (Closed)

Created:
7 years, 7 months ago by yael.aharon

Modified:
7 years, 7 months ago

Reviewers:
Peter Beverloo, abarth-chromium, yael.aharon1, tkent, eseidel, tkent

CC:
blink-reviews, jamesr, eae+blinkwatch, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add runtime flag for PagePopup. This is the first in a list of 3 patches to remove the runtime flag ENABLE(PAGE_POPUP). BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150413

Patch Set 2 : Alphabetized #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
M	Source/WebKit/chromium/public/WebRuntimeFeatures.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/WebKit/chromium/src/WebRuntimeFeatures.cpp	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	Source/core/page/RuntimeEnabledFeatures.in	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

yael.aharon1

This is the first of three patches, based on tkent's recommendation in https://codereview.chromium.org/14735003/#msg17 . Can ...

7 years, 7 months ago (2013-05-15 00:17:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yael.aharon@intel.com/15178007/1

7 years, 7 months ago (2013-05-15 00:25:43 UTC) #3

abarth-chromium

https://chromiumcodereview.appspot.com/15178007/diff/1/Source/core/page/RuntimeEnabledFeatures.in File Source/core/page/RuntimeEnabledFeatures.in (right): https://chromiumcodereview.appspot.com/15178007/diff/1/Source/core/page/RuntimeEnabledFeatures.in#newcode64 Source/core/page/RuntimeEnabledFeatures.in:64: PagePopup status=stable Please alphabetize. :)

7 years, 7 months ago (2013-05-15 01:02:36 UTC) #4

tkent

> Source/core/page/RuntimeEnabledFeatures.in:64: PagePopup status=stable > Please alphabetize. :) oh, right. Stopped commit-bot.

7 years, 7 months ago (2013-05-15 02:10:08 UTC) #5

yael.aharon1

On 2013/05/15 02:10:08, tkent wrote: > > Source/core/page/RuntimeEnabledFeatures.in:64: PagePopup status=stable > > Please alphabetize. :) ...

7 years, 7 months ago (2013-05-15 02:16:33 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yael.aharon@intel.com/15178007/9001

7 years, 7 months ago (2013-05-15 02:19:05 UTC) #7

Message was sent while issue was closed.

Change committed as 150413

Expand Messages | Collapse Messages