Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15177003: Add Sync data type for managed users. (Closed)

Created:
7 years, 7 months ago by Bernhard Bauer
Modified:
7 years, 7 months ago
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Patch Set 4 : . #

Patch Set 5 : fix #

Patch Set 6 : sync #

Total comments: 6

Patch Set 7 : review #

Total comments: 2

Patch Set 8 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -7 lines) Patch
M chrome/browser/sync/glue/model_association_manager.cc View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_prefs.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M sync/internal_api/base_node.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M sync/internal_api/public/base/model_type.h View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M sync/internal_api/public/base_node.h View 1 chunk +4 lines, -0 lines 0 comments Download
M sync/internal_api/public/write_node.h View 1 chunk +4 lines, -0 lines 0 comments Download
M sync/internal_api/write_node.cc View 1 chunk +7 lines, -0 lines 0 comments Download
A sync/protocol/managed_user_specifics.proto View 1 2 3 4 5 6 1 chunk +26 lines, -0 lines 0 comments Download
M sync/protocol/proto_value_conversions.h View 2 chunks +4 lines, -0 lines 0 comments Download
M sync/protocol/proto_value_conversions.cc View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M sync/protocol/proto_value_conversions_unittest.cc View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M sync/protocol/sync.proto View 2 chunks +2 lines, -0 lines 0 comments Download
M sync/sync_proto.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M sync/syncable/model_type.cc View 1 2 11 chunks +25 lines, -0 lines 0 comments Download
M sync/syncable/nigori_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/tools/testserver/chromiumsync.py View 5 chunks +7 lines, -1 line 0 comments Download
M sync/util/data_type_histogram.h View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Bernhard Bauer
Please review.
7 years, 7 months ago (2013-05-20 21:12:28 UTC) #1
tim (not reviewing)
https://codereview.chromium.org/15177003/diff/29001/chrome/browser/sync/glue/model_association_manager.cc File chrome/browser/sync/glue/model_association_manager.cc (right): https://codereview.chromium.org/15177003/diff/29001/chrome/browser/sync/glue/model_association_manager.cc#newcode45 chrome/browser/sync/glue/model_association_manager.cc:45: syncer::MANAGED_USERS, Since association for each of these types happens ...
7 years, 7 months ago (2013-05-23 18:23:27 UTC) #2
Bernhard Bauer
https://codereview.chromium.org/15177003/diff/29001/chrome/browser/sync/glue/model_association_manager.cc File chrome/browser/sync/glue/model_association_manager.cc (right): https://codereview.chromium.org/15177003/diff/29001/chrome/browser/sync/glue/model_association_manager.cc#newcode45 chrome/browser/sync/glue/model_association_manager.cc:45: syncer::MANAGED_USERS, On 2013/05/23 18:23:27, timsteele wrote: > Since association ...
7 years, 7 months ago (2013-05-23 20:08:16 UTC) #3
tim (not reviewing)
LGTM https://codereview.chromium.org/15177003/diff/41001/sync/internal_api/public/base/model_type.h File sync/internal_api/public/base/model_type.h (right): https://codereview.chromium.org/15177003/diff/41001/sync/internal_api/public/base/model_type.h#newcode99 sync/internal_api/public/base/model_type.h:99: // by this user and can have restrictions ...
7 years, 7 months ago (2013-05-24 03:55:50 UTC) #4
Bernhard Bauer
Drew: TBR for sync_setup_handler.cc (updating an enum count). https://codereview.chromium.org/15177003/diff/41001/sync/internal_api/public/base/model_type.h File sync/internal_api/public/base/model_type.h (right): https://codereview.chromium.org/15177003/diff/41001/sync/internal_api/public/base/model_type.h#newcode99 sync/internal_api/public/base/model_type.h:99: // ...
7 years, 7 months ago (2013-05-24 05:06:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/15177003/54001
7 years, 7 months ago (2013-05-24 05:07:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/15177003/54001
7 years, 7 months ago (2013-05-24 05:12:45 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-24 09:20:42 UTC) #8
Message was sent while issue was closed. 
Change committed as 202026

Powered by Google App Engine
This is Rietveld 408576698