Sort points for PDF's draw rect, to match raster and GPU implementation.

Sort points for PDF's draw rect, to match raster and GPU implementation.

Committed: http://code.google.com/p/skia/source/detail?r=9125

[vandebo (ex-Chrome), 2013-05-14 16:43:34]

Does this otherwise fix a bug, or it just to match the other implementation's
behavior?  If the later, maybe the sorting should be done by SkCanvas?

LGTM

[edisonn, 2013-05-14 17:08:40]

On 2013/05/14 16:43:34, vandebo wrote:
> Does this otherwise fix a bug, or it just to match the other implementation's
> behavior?  If the later, maybe the sorting should be done by SkCanvas?
> 
> LGTM

it fixes second issue listed in
https://code.google.com/p/skia/issues/detail?id=1292
If I put the change in canvas, other entry points that might end up calling
device::drawRect, will have to be maintained. But I can put it in canvas if Cary
is fine with this.

[vandebo (ex-Chrome), 2013-05-14 17:14:33]

On 2013/05/14 17:08:40, edisonn wrote:
> On 2013/05/14 16:43:34, vandebo wrote:
> > Does this otherwise fix a bug, or it just to match the other
implementation's
> > behavior?  If the later, maybe the sorting should be done by SkCanvas?
> > 
> > LGTM
> 
> it fixes second issue listed in
> https://code.google.com/p/skia/issues/detail?id=1292
> If I put the change in canvas, other entry points that might end up calling
> device::drawRect, will have to be maintained. But I can put it in canvas if
Cary
> is fine with this.

Either way, it's good to reference a bug in change descriptions so that it's
easy to see why a change was made.

[caryclark, 2013-05-14 17:43:26]

lgtm

https://codereview.chromium.org/15162005/diff/3001/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/15162005/diff/3001/src/pdf/SkPDFDevice.cpp#ne...
src/pdf/SkPDFDevice.cpp:791: r.sort();
putting the change in the canvas will change other behavior, like dashing

[commit-bot: I haz the power, 2013-05-14 17:44:52]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/edisonn@google.com/15162005/3001

[commit-bot: I haz the power, 2013-05-14 18:16:43]

Change committed as 9125