filter/dscache/ds.go - Issue 1516173002: Fix error message from KeyForObj when passing an invalid struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: filter/dscache/ds.go

Issue 1516173002: Fix error message from KeyForObj when passing an invalid struct. (Closed) Base URL: https://github.com/luci/gae.git@master

Patch Set: remove accidental extra test Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: filter/dscache/ds.go

diff --git a/filter/dscache/ds.go b/filter/dscache/ds.go

index 36b308e4644e4ad7d7a2c0016ae04a31e311fded..910727fe7d4d1d7d294d0e15f01afffdfc5ec993 100644

--- a/filter/dscache/ds.go

+++ b/filter/dscache/ds.go

@@ -87,7 +87,8 @@ func (d *dsCache) GetMulti(keys []*ds.Key, metas ds.MultiMetaGetter, cb ds.GetMu

if toSave != nil {

if shouldSave { // save

- expSecs := metas.GetMetaDefault(i, CacheExpirationMeta, CacheTimeSeconds).(int64)

+ mg := metas.GetSingle(i)

+ expSecs := ds.GetMetaDefault(mg, CacheExpirationMeta, CacheTimeSeconds).(int64)

toSave.SetFlags(uint32(ItemHasData))

toSave.SetExpiration(time.Duration(expSecs) * time.Second)

toSave.SetValue(data)

« no previous file with comments | « no previous file | filter/dscache/support.go » ('j') | service/datastore/pls.go » ('J')