Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: service/datastore/properties_test.go

Issue 1516173002: Fix error message from KeyForObj when passing an invalid struct. (Closed) Base URL: https://github.com/luci/gae.git@master
Patch Set: Fix GetMetaDefault silliness Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package datastore 5 package datastore
6 6
7 import ( 7 import (
8 "math" 8 "math"
9 "testing" 9 "testing"
10 "time" 10 "time"
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 pm := PropertyMap{"": {MkProperty("trap!")}} 145 pm := PropertyMap{"": {MkProperty("trap!")}}
146 _, err := pm.GetMeta("foo") 146 _, err := pm.GetMeta("foo")
147 So(err, ShouldEqual, ErrMetaFieldUnset) 147 So(err, ShouldEqual, ErrMetaFieldUnset)
148 148
149 err = pm.SetMeta("foo", 100) 149 err = pm.SetMeta("foo", 100)
150 So(err, ShouldBeNil) 150 So(err, ShouldBeNil)
151 151
152 v, err := pm.GetMeta("foo") 152 v, err := pm.GetMeta("foo")
153 So(err, ShouldBeNil) 153 So(err, ShouldBeNil)
154 So(v, ShouldEqual, 100) 154 So(v, ShouldEqual, 100)
155 » » » » So(pm.GetMetaDefault("foo", 100), ShouldEqual, 1 00) 155
156 » » » » So(pm.GetMetaDefault("bar", 100), ShouldEqual, 1 00) 156 » » » » v, err = GetMetaDefault(pm, "foo", 100)
157 » » » » So(err, ShouldBeNil)
158 » » » » So(v, ShouldEqual, 100)
159
160 » » » » v, err = GetMetaDefault(pm, "bar", 100)
161 » » » » So(err, ShouldBeNil)
162 » » » » So(v, ShouldEqual, 100)
157 163
158 npm, err := pm.Save(false) 164 npm, err := pm.Save(false)
159 So(err, ShouldBeNil) 165 So(err, ShouldBeNil)
160 So(len(npm), ShouldEqual, 0) 166 So(len(npm), ShouldEqual, 0)
161 }) 167 })
162 168
163 Convey("errors", func() { 169 Convey("errors", func() {
164 Convey("too many values", func() { 170 Convey("too many values", func() {
165 pm := PropertyMap{ 171 pm := PropertyMap{
166 "$bad": {MkProperty(100), MkProp erty(200)}, 172 "$bad": {MkProperty(100), MkProp erty(200)},
167 } 173 }
168 _, err := pm.GetMeta("bad") 174 _, err := pm.GetMeta("bad")
169 So(err.Error(), ShouldContainSubstring, "too many values") 175 So(err.Error(), ShouldContainSubstring, "too many values")
170 }) 176 })
171 177
172 Convey("weird value", func() { 178 Convey("weird value", func() {
173 pm := PropertyMap{} 179 pm := PropertyMap{}
174 err := pm.SetMeta("sup", complex(100, 20 )) 180 err := pm.SetMeta("sup", complex(100, 20 ))
175 So(err.Error(), ShouldContainSubstring, "bad type") 181 So(err.Error(), ShouldContainSubstring, "bad type")
176 }) 182 })
177 }) 183 })
178 }) 184 })
179 }) 185 })
180 } 186 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698