Begin moving DeprecatedStyleBuilder properties to new generated StyleBuilder.

Begin moving DeprecatedStyleBuilder properties to new generated StyleBuilder.

This patch starts off the new generated StyleBuilder with the properties that
used to have an ApplyPropertyDefault handler. Subsequent patches will move over
the other handler types (length, computelength, auto, font, etc.) as well as
allow for custom property handling routines.

To start off with we're just generating a giant switch statement. Once we have
sufficiently many (or all) properties in the new system, we can test other
ideas, e.g. a function lookup table, for performance and binary size.

BUG=237400
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150424

[Timothy Loh, 2013-05-14 05:22:58]

r?

[eseidel, 2013-05-14 05:35:00]

Sounds great.  How to plan to test the awesomeness of the autogen code? 
Performance testing?  Compare to the existing switch?  Autogen'd correctness
tests (to show cases where we previously had hand-coded wrong?)

[Timothy Loh, 2013-05-14 07:12:54]

On 2013/05/14 05:35:00, Eric Seidel wrote:
> Sounds great.  How to plan to test the awesomeness of the autogen code? 
> Performance testing?  Compare to the existing switch?  Autogen'd correctness
> tests (to show cases where we previously had hand-coded wrong?)

Probably it'll be hard to compare performance with the existing and new systems
if the move is spread over many patches, but I'll make sure to try various ideas
for this once we have most of the properties moved over. I didn't see any
noticeable difference when I was working on the previous WIP patch which had
~170 properties. It'll be super easy to try various options (switch statement /
lookup table / ???) -- the DeprecatedStyleBuilder basically uses a lookup table,
so we know that option will be at least as good as what we have currently.

Binary size of the chrome executable is down 57kB (134253960 -> 134197000) from
this patch. Maybe this'll be nicer to the cache (and I imagine we'll save more
size as we move more properties).

[dglazkov, 2013-05-14 14:56:30]

Awesome stuff, timloh!

[eseidel, 2013-05-15 06:25:28]

This seems fine.  I'd like to see the generated output.  Can you pastebin that?

https://codereview.chromium.org/15157002/diff/1/Source/core/css/CSSProperties.in
File Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/15157002/diff/1/Source/core/css/CSSProperties...
Source/core/css/CSSProperties.in:1: // FIXME: When we have all the properties
using the new StyleBuilder, we
Why can't we share this with CSSPRopertyNames.in already?

[Timothy Loh, 2013-05-15 06:34:01]

On 2013/05/15 06:25:28, eseidel wrote:
> This seems fine.  I'd like to see the generated output.  Can you pastebin
that?

http://pastebin.com/vebnLJk9

>
https://codereview.chromium.org/15157002/diff/1/Source/core/css/CSSProperties.in
> File Source/core/css/CSSProperties.in (right):
> 
>
https://codereview.chromium.org/15157002/diff/1/Source/core/css/CSSProperties...
> Source/core/css/CSSProperties.in:1: // FIXME: When we have all the properties
> using the new StyleBuilder, we
> Why can't we share this with CSSPRopertyNames.in already?

I guess we can, I'll add a flag for the properties which are still using the
StyleResolver / DeprecatedStyleBuilder.

[Timothy Loh, 2013-05-15 06:51:27]

On 2013/05/15 06:34:01, Timothy Loh wrote:
> I guess we can, I'll add a flag for the properties which are still using the
> StyleResolver / DeprecatedStyleBuilder.

On second thoughts, not doing this right now.

I've moved the call to below the DeprecatedStyleBuilder so that the main handler
is hit first.

[eseidel, 2013-05-15 06:57:30]

lgtm

Thanks.  We need a strategy for testing the perf of this to make sure we're
making it faster.

I'm sure we'll iterate much from here, but I want to keep you moving forward.

[commit-bot: I haz the power, 2013-05-15 06:57:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timloh@chromium.org/15157002/8001

[eseidel, 2013-05-15 06:58:05]

I spoke with Tim over IM and received assurances that he would finish what he
started and that we would not end up with another partially done re-write like
the template-based builder.

[eseidel, 2013-05-15 07:00:09]

Another resolution for this might be to do this work on a branch. I'm not sure. 
Most of this is about building up the harness and the knowledge of all the
quirks of the various properties.

Again, I"m most concenred that we need to test taht we're getting better as we
do this. I suspect converting more properties should be largely mechanical at
this point.

[commit-bot: I haz the power, 2013-05-15 14:11:45]

Change committed as 150424