Use a single Python Forwarder instance for each base test runner instance.

build/android/pylib/base/base_test_runner.py

Index: build/android/pylib/base/base_test_runner.py
diff --git a/build/android/pylib/base/base_test_runner.py b/build/android/pylib/base/base_test_runner.py
index 9316a0f695b1e99c1c69e55d5a6f4dd05761c6d9..d4233fa43287c695233376c34f63a8b7eae8a07d 100644
--- a/build/android/pylib/base/base_test_runner.py
+++ b/build/android/pylib/base/base_test_runner.py
@@ -125,12 +125,11 @@ class BaseTestRunner(object):
     self.StartForwarderForHttpServer()
     return (self._forwarder_device_port, self._http_server.port)
 
-  def _CreateAndRunForwarder(
-      self, adb, port_pairs, tool, host_name, build_type):
-    """Creates and run a forwarder."""
-    forwarder = Forwarder(adb, build_type)
-    forwarder.Run(port_pairs, tool, host_name)
-    return forwarder
+  def _ForwardPort(self, port_pairs):
+    """Creates a forwarder instance if needed and forward a port."""
+    if not self._forwarder:
+      self._forwarder = Forwarder(self.adb, self.build_type)
+    self._forwarder.Run(port_pairs, self.tool, '127.0.0.1')
 
   def StartForwarder(self, port_pairs):
     """Starts TCP traffic forwarding for the given |port_pairs|.
@@ -138,17 +137,14 @@ class BaseTestRunner(object):
     Args:
       host_port_pairs: A list of (device_port, local_port) tuples to forward.
     """
-    if self._forwarder:
-      self._forwarder.Close()
-    self._forwarder = self._CreateAndRunForwarder(
-        self.adb, port_pairs, self.tool, '127.0.0.1', self.build_type)
+    self._ForwardPort(port_pairs)
 
   def StartForwarderForHttpServer(self):
     """Starts a forwarder for the HTTP server.
 
     The forwarder forwards HTTP requests and responses between host and device.
     """
-    self.StartForwarder([(self._forwarder_device_port, self._http_server.port)])
+    self._ForwardPort([(self._forwarder_device_port, self._http_server.port)])
 
   def RestartHttpServerForwarderIfNecessary(self):
     """Restarts the forwarder if it's not open."""
@@ -189,12 +185,13 @@ class BaseTestRunner(object):
     error_msgs = []
     # Try 3 times to launch test spawner server.
     for i in xrange(0, 3):

[frankf, 2013/05/15 17:24:30]

Could you explain this magic and the sleep below? What can cause a failure to
launch test spawner server?

[Philippe, 2013/05/15 17:57:41]

No idea, I'm not the author here. I would be tempted to remove the for loop and
the sleep. This looks flaky.

Also IsHttpServerConnectable() looks less than ideal. Ideally
spawning_server.Start() should block until the server is ready rather than
requiring the client to implement a flaky logic (I'm sure there is a reason
behind this though).

But I would prefer to address these things in a separate CL. The current CL is
already impactful enough.

[frankf, 2013/05/15 18:00:35]

sg. Please add a TODO.

On 2013/05/15 17:57:41, Philippe wrote:

-      # Do not allocate port for test server here. We will allocate
-      # different port for individual test in TestServerThread.
       self.test_server_spawner_port = ports.AllocateTestServerPort()
+      self._ForwardPort(
+          [(self.test_server_spawner_port, self.test_server_spawner_port)])
       self._spawning_server = SpawningServer(self.test_server_spawner_port,
                                              self.adb,
                                              self.tool,
+                                             self._forwarder,
                                              self.build_type)
       self._spawning_server.Start()
       server_ready, error_msg = ports.IsHttpServerConnectable(
@@ -211,7 +208,3 @@ class BaseTestRunner(object):
       logging.error(';'.join(error_msgs))
       raise Exception('Can not start the test spawner server.')
     self._PushTestServerPortInfoToDevice()
-    self._spawner_forwarder = self._CreateAndRunForwarder(
-        self.adb,
-        [(self.test_server_spawner_port, self.test_server_spawner_port)],
-        self.tool, '127.0.0.1', self.build_type)