Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 15139006: Remove enable-pinch-zoom-scrollbars flag. (Closed)

Created:
7 years, 7 months ago by wjmaclean
Modified:
7 years, 7 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, cc-bugs_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove enable-pinch-zoom-scrollbars flag. As part of the cleanup before re-factoring code to implement the pinch virtual viewport for fixed position elements and pinch-zoom scrollbars, we need to remove this now-obsolete flag. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200922

Patch Set 1 #

Patch Set 2 : Rebase to fix merge errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M cc/base/switches.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M cc/base/switches.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
wjmaclean
Removing a flag prior to re-factoring ... can you all please take a look?
7 years, 7 months ago (2013-05-16 14:49:13 UTC) #1
jamesr
lgtm
7 years, 7 months ago (2013-05-17 02:06:00 UTC) #2
sky
LGTM
7 years, 7 months ago (2013-05-17 15:03:45 UTC) #3
Daniel Erat
lgtm
7 years, 7 months ago (2013-05-17 17:19:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/15139006/1
7 years, 7 months ago (2013-05-17 17:22:56 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome/app/generated_resources.grd: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-17 17:22:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/15139006/7001
7 years, 7 months ago (2013-05-17 19:38:33 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-17 23:28:50 UTC) #8
Message was sent while issue was closed.
Change committed as 200922

Powered by Google App Engine
This is Rietveld 408576698