Issue 15137010: Don't tell people they can import their own roots on iOS.

Issue 15137010: Don't tell people they can import their own roots on iOS. (Closed)

Created:
7 years, 7 months ago by palmer

Modified:
7 years, 7 months ago

Reviewers:
pink (ping after 24hrs), stuartmorgan, Ryan Sleevi, abarth-chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't tell people they can import their own roots on iOS. It's not possible at this time. BUG=240640 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200143

Patch Set 2 : Only show a third paragraph on platforms that have one to show. #

Patch Set 3 : Update the grit whitelist too. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
M	build/ios/grit_whitelist.txt	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/app/generated_resources.grd	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ssl/ssl_error_info.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

NACK You still need to update https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ssl/ssl_error_info.cc&sq=package:chromium&q=IDS_CERT_ERROR_AUTHORITY_INVALID_EXTRA_INFO_3&l=117 , since any entries in extra_info will be ...

7 years, 7 months ago (2013-05-14 19:13:53 UTC) #2

palmer

Updated chrome/browser/ssl/ssl_error_info.cc. Adding abarth as an OWNER for that file.

7 years, 7 months ago (2013-05-14 19:34:45 UTC) #3

Ryan Sleevi

Looks like you'll also want to touch build/ios/grit_whitelist.txt LGTM, but you'll want to confirm with ...

7 years, 7 months ago (2013-05-14 19:37:41 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/15137010/9001

7 years, 7 months ago (2013-05-14 21:35:36 UTC) #6

Message was sent while issue was closed.

Change committed as 200143

Expand Messages | Collapse Messages