Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1704)

Unified Diff: cc/trees/remote_proto_channel.h

Issue 1513643010: cc:: Add remote mode to the compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed vmpstr's comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/remote_channel_unittest.cc ('k') | cc/trees/threaded_channel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/remote_proto_channel.h
diff --git a/cc/trees/remote_proto_channel.h b/cc/trees/remote_proto_channel.h
index b0f1647e281a8f96e0cf77636a41c62d5267581e..76141a9089405ceb1b552fbef2a51476356723b9 100644
--- a/cc/trees/remote_proto_channel.h
+++ b/cc/trees/remote_proto_channel.h
@@ -6,6 +6,7 @@
#define CC_TREES_REMOTE_PROTO_CHANNEL_H_
#include "base/memory/scoped_ptr.h"
+#include "cc/base/cc_export.h"
namespace cc {
@@ -15,12 +16,14 @@ class CompositorMessage;
// Provides a bridge for getting compositor protobuf messages to/from the
// outside world.
-class RemoteProtoChannel {
+class CC_EXPORT RemoteProtoChannel {
public:
// Meant to be implemented by a RemoteChannel that needs to receive and parse
// incoming protobufs.
- class ProtoReceiver {
+ class CC_EXPORT ProtoReceiver {
public:
+ // TODO(khushalsagar): This should probably include a closure that returns
+ // the status of processing this proto. See crbug/576974
virtual void OnProtoReceived(
scoped_ptr<proto::CompositorMessage> proto) = 0;
@@ -28,7 +31,10 @@ class RemoteProtoChannel {
virtual ~ProtoReceiver() {}
};
+ // Called by the ProtoReceiver. The RemoteProtoChannel must outlive its
+ // receiver.
virtual void SetProtoReceiver(ProtoReceiver* receiver) = 0;
+
virtual void SendCompositorProto(const proto::CompositorMessage& proto) = 0;
protected:
« no previous file with comments | « cc/trees/remote_channel_unittest.cc ('k') | cc/trees/threaded_channel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698