Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1393)

Unified Diff: cc/playback/display_item_list_unittest.cc

Issue 1512823002: Serialize DisplayListRecordingSource to protos. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/playback/display_item_list_unittest.cc
diff --git a/cc/playback/display_item_list_unittest.cc b/cc/playback/display_item_list_unittest.cc
index b29baa3735e8a44ba233f87950fbd10792b77723..09a3ce8753f326572e31b16a41d5c63087784f3f 100644
--- a/cc/playback/display_item_list_unittest.cc
+++ b/cc/playback/display_item_list_unittest.cc
@@ -84,22 +84,8 @@ void ValidateDisplayItemListSerialization(const gfx::Size& layer_size,
scoped_refptr<DisplayItemList> new_list =
DisplayItemList::CreateFromProto(proto);
- // Finalize the DisplayItemLists to perform raster.
- new_list->Finalize();
-
- const int pixel_size = 4 * layer_size.GetArea();
-
- // Get the rendered contents of the old DisplayItemList.
- scoped_ptr<unsigned char[]> pixels(new unsigned char[pixel_size]);
- memset(pixels.get(), 0, pixel_size);
- DrawDisplayList(pixels.get(), gfx::Rect(layer_size), list);
-
- // Get the rendered contents of the new DisplayItemList.
- scoped_ptr<unsigned char[]> new_pixels(new unsigned char[pixel_size]);
- memset(new_pixels.get(), 0, pixel_size);
- DrawDisplayList(new_pixels.get(), gfx::Rect(layer_size), new_list);
-
- EXPECT_EQ(0, memcmp(pixels.get(), new_pixels.get(), pixel_size));
+ EXPECT_TRUE(
+ CompareDisplayListDrawingResults(gfx::Rect(layer_size), list, new_list));
vmpstr 2015/12/10 18:55:44 naming nit: If this is going to return true maybe
David Trainor- moved to gerrit 2015/12/10 21:51:27 Exactly the same length. Wut.
vmpstr 2015/12/10 21:55:49 Skillz.
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698