chrome/test/data/extensions/api_test/service_worker/update_without_skip_waiting/v2/sw.js - Issue 1510573003: Add test without skipWaiting() to demonstrate extension & service worker update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/service_worker/update_without_skip_waiting/v2/sw.js

Issue 1510573003: Add test without skipWaiting() to demonstrate extension & service worker update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address nits from falken@ Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/service_worker/update_without_skip_waiting/v2/page.js ('K') | « chrome/test/data/extensions/api_test/service_worker/update_without_skip_waiting/v2/page.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/service_worker/update_without_skip_waiting/v2/sw.js

diff --git a/chrome/test/data/extensions/api_test/service_worker/update/v2/sw.js b/chrome/test/data/extensions/api_test/service_worker/update_without_skip_waiting/v2/sw.js

similarity index 78%

copy from chrome/test/data/extensions/api_test/service_worker/update/v2/sw.js

copy to chrome/test/data/extensions/api_test/service_worker/update_without_skip_waiting/v2/sw.js

index a33255c974a272d2cd7100bdd3513b7594957db4..d2720f6196dd6a2f5835f21af9c71201d85b8784 100644

--- a/chrome/test/data/extensions/api_test/service_worker/update/v2/sw.js

+++ b/chrome/test/data/extensions/api_test/service_worker/update_without_skip_waiting/v2/sw.js

@@ -6,6 +6,4 @@ this.onmessage = function(e) {

e.ports[0].postMessage('Pong from version 2');

};

-this.oninstall = function(e) {

- e.waitUntil(self.skipWaiting());

-};

+// Does not call self.skipWaiting() from oninstall handler.