Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 15102010: untangle pango usage from use_x11 and OS==linux (Closed)

Created:
7 years, 7 months ago by Mostyn Bramley-Moore
Modified:
7 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

untangle pango usage from use_x11 and OS==linux This allows pango to be toggled independently of X11 and linux. It defaults to enabled on these. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201892

Patch Set 1 #

Patch Set 2 : rebase on master #

Patch Set 3 : remove stray unit test inclusion (bad rebase?) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -68 lines) Patch
M build/common.gypi View 1 2 chunks +4 lines, -1 line 0 comments Download
D content/common/font_list_linux.cc View 1 chunk +0 lines, -43 lines 0 comments Download
A + content/common/font_list_pango.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/content_browser.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 2 chunks +6 lines, -2 lines 0 comments Download
M ui/ui.gyp View 1 7 chunks +11 lines, -16 lines 0 comments Download
M ui/ui_unittests.gypi View 1 2 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Mostyn Bramley-Moore
This is an updated version of https://codereview.chromium.org/14181002/ (submitted by spang). Added jam & brettw to ...
7 years, 7 months ago (2013-05-13 19:51:30 UTC) #1
Ben Goodger (Google)
ui lgtm
7 years, 7 months ago (2013-05-14 16:52:29 UTC) #2
brettw
content lgtm. In the future, please only add one owners reviewer per area to cut ...
7 years, 7 months ago (2013-05-21 18:05:24 UTC) #3
Mostyn Bramley-Moore
On 2013/05/21 18:05:24, brettw wrote: > content lgtm. In the future, please only add one ...
7 years, 7 months ago (2013-05-21 18:09:47 UTC) #4
Paweł Hajdan Jr.
build/common.gypi LGTM Thanks for the change!
7 years, 7 months ago (2013-05-22 19:41:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/15102010/1
7 years, 7 months ago (2013-05-22 19:43:40 UTC) #6
commit-bot: I haz the power
Failed to apply patch for ui/ui_unittests.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-22 19:43:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/15102010/9001
7 years, 7 months ago (2013-05-22 19:55:01 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-22 21:31:11 UTC) #9
Mostyn Bramley-Moore
Patch set 3 removed some stray test inclusion from ui/ui_unittests.gypi (which was accidentally introduced in ...
7 years, 7 months ago (2013-05-22 21:37:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/15102010/24002
7 years, 7 months ago (2013-05-22 21:39:05 UTC) #11
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=42935
7 years, 7 months ago (2013-05-23 11:43:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/15102010/24002
7 years, 7 months ago (2013-05-23 17:22:38 UTC) #13
commit-bot: I haz the power
7 years, 7 months ago (2013-05-23 21:44:16 UTC) #14
Message was sent while issue was closed.
Change committed as 201892

Powered by Google App Engine
This is Rietveld 408576698