Issue 15102003: Set CHROMIUM_BUILD and friends when building with ninja too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15102003: Set CHROMIUM_BUILD and friends when building with ninja too. (Closed)

Created:
7 years, 7 months ago by Nico

Modified:
7 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org

Base URL:
http://src.chromium.org/chrome/trunk/tools/build/

Visibility:
Public.

Set CHROMIUM_BUILD and friends when building with ninja too. Google Chrome Linux complains about this env var not being set: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/40427/steps/compile/logs/stdio FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/rpm/build.sh -o../out/Release -b ../out/Release -a x64 -c stable ../out/Release/installer/rpm/build.sh: line 253: CHROMIUM_BUILD: unbound variable BUG=239257 TBR=thestig@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=199604

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -14 lines)			Patch
	M	scripts/slave/compile.py	View		4 chunks	+14 lines, -14 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/15102003/1

7 years, 7 months ago (2013-05-11 03:53:56 UTC) #2

Message was sent while issue was closed.

lgtm